Mailing-List: contact jspwiki-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jspwiki-dev@incubator.apache.org
Date: Thu, 1 Mar 2012 21:55:58 +0000 (UTC)
From: =?utf-8?Q?Juan_Pablo_Santos_Rodr=C3=ADguez_=28Commented=29_=28JIRA=29?=
 <jira@apache.org>
To: jspwiki-dev@incubator.apache.org
Message-ID: 
 <1865898239.9061.1330638958465.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <225334504.27836.1330434768309.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (JSPWIKI-722) Build broken under jdk 1.7
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/JSPWIKI-722?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D132=
20403#comment-13220403 ]=20

Juan Pablo Santos Rodr=C3=ADguez commented on JSPWIKI-722:
-----------------------------------------------------

Hello Mike,

unfortunately, we can't apply the attached patch: the build is targetted fo=
r Java 1.5 and the patch breaks this:
- first, it uses SQLFeatureNotSupportedException, which is only available u=
nder Java 6 and onwards.
- second, it's annotated with @Override, which, under a JDK6 (or downwards)=
 isn't true.

So, to include the patch, getParentLogger should not throw any exception in=
 its signature (also it could possibly return null), and it should not be a=
nnotated with @Override

It would be nice to have this in the upcoming RC, so if you attach a new pa=
tch we can include it on trunk + 2.8 branch.
               =20
> Build broken under jdk 1.7
> --------------------------
>
>                 Key: JSPWIKI-722
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-722
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Servlet Container/Java compatibility
>    Affects Versions: 2.8.5
>         Environment: JDK 1.7
>            Reporter: Mike Morris
>            Priority: Minor
>              Labels: newbie
>         Attachments: getParentLoggerPatch.diff
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Attempting to build under JDK 1.7 causes a compile failure on test class =
org.apache.wiki.TestJDBCDataSource.
> JDK1.7 introduces a new method getParentLogger() in javax.sql.CommonDataS=
ource which is not implemented by TestJDBCDataSource.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira