incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Juan Pablo Santos Rodríguez (Commented) (JIRA) <j...@apache.org>
Subject [jira] [Commented] (JSPWIKI-722) Build broken under jdk 1.7
Date Thu, 01 Mar 2012 21:55:58 GMT

    [ https://issues.apache.org/jira/browse/JSPWIKI-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220403#comment-13220403
] 

Juan Pablo Santos Rodríguez commented on JSPWIKI-722:
-----------------------------------------------------

Hello Mike,

unfortunately, we can't apply the attached patch: the build is targetted for Java 1.5 and
the patch breaks this:
- first, it uses SQLFeatureNotSupportedException, which is only available under Java 6 and
onwards.
- second, it's annotated with @Override, which, under a JDK6 (or downwards) isn't true.

So, to include the patch, getParentLogger should not throw any exception in its signature
(also it could possibly return null), and it should not be annotated with @Override

It would be nice to have this in the upcoming RC, so if you attach a new patch we can include
it on trunk + 2.8 branch.
                
> Build broken under jdk 1.7
> --------------------------
>
>                 Key: JSPWIKI-722
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-722
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Servlet Container/Java compatibility
>    Affects Versions: 2.8.5
>         Environment: JDK 1.7
>            Reporter: Mike Morris
>            Priority: Minor
>              Labels: newbie
>         Attachments: getParentLoggerPatch.diff
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Attempting to build under JDK 1.7 causes a compile failure on test class org.apache.wiki.TestJDBCDataSource.
> JDK1.7 introduces a new method getParentLogger() in javax.sql.CommonDataSource which
is not implemented by TestJDBCDataSource.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message