incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vigneshwaran Raveendran (Created) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (JSPWIKI-712) Entities in ChangeNote should be decoded when "keep editing"
Date Tue, 20 Dec 2011 09:35:30 GMT
Entities in ChangeNote should be decoded when "keep editing"
------------------------------------------------------------

                 Key: JSPWIKI-712
                 URL: https://issues.apache.org/jira/browse/JSPWIKI-712
             Project: JSPWiki
          Issue Type: Bug
          Components: Default template
    Affects Versions: 2.8.4
         Environment: Windows XP, Tomcat 7.0
            Reporter: Vigneshwaran Raveendran
            Priority: Minor


Steps to reproduce the bug:-
1. Go here: http://doc.jspwiki.org/2.4/Edit.jsp?page=WindowsInstall
2. Type in changenote: Testing "quotes" & ampersand
3. Click preview
4. Click Keep Editing
5. The changenote looks like this: Testing &amp;quot;quotes&amp;quot; &amp;amp;
ampersand

Now the user has to remove it and type (Testing "quotes" & ampersand) again before saving.
If the user didn't notice it, then the comment will be saved as "Testing &amp;quot;quotes&amp;quot;
&amp;amp; ampersand" in the history.

=================================================

I know that entities need to be encoded for security reasons but this is a Bug.

When "keep editing" button is clicked, the comment should appear in decoded format. For that,
there should be a javascript that execute "after" the page is loaded. No need to change any
of the TextUtil.replaceEntities() methods.

=================================================

This is how I fixed it in my pc:
1. Added the following script to commonheader.jsp (or prettify.js)

<script type="text/javascript">
function decodeChangeNote() {
document.getElementById("changenote").value = 
  document.getElementById("changenote").value
    .replace(/&amp;amp;/g,"&")
    .replace(/&amp;lt;/g,"<")
    .replace(/&amp;gt;/g,">")
    .replace(/&amp;quot;/g,"\"");
}
</script>


2. Changed <body> tag in EditTemplate.jsp to call this js function on load.

<body onload="decodeChangeNote()">

====================================================

Now JSPWiki works fine for me. Polish this fix if needed and commit it. Please correct me
if I'm wrong.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message