Return-Path: X-Original-To: apmail-incubator-jspwiki-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-jspwiki-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 19A2F4524 for ; Fri, 13 May 2011 07:35:54 +0000 (UTC) Received: (qmail 19376 invoked by uid 500); 13 May 2011 07:35:54 -0000 Delivered-To: apmail-incubator-jspwiki-dev-archive@incubator.apache.org Received: (qmail 19269 invoked by uid 500); 13 May 2011 07:35:44 -0000 Mailing-List: contact jspwiki-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jspwiki-dev@incubator.apache.org Delivered-To: mailing list jspwiki-dev@incubator.apache.org Received: (qmail 19220 invoked by uid 99); 13 May 2011 07:35:27 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 May 2011 07:35:27 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 May 2011 07:35:26 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id D879688632 for ; Fri, 13 May 2011 07:34:47 +0000 (UTC) Date: Fri, 13 May 2011 07:34:47 +0000 (UTC) From: =?utf-8?Q?Juan_Pablo_Santos_Rodr=C3=ADguez_=28JIRA=29?= To: jspwiki-dev@incubator.apache.org Message-ID: <1823347743.9256.1305272087883.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <2121007483.27785.1304676003787.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Resolved] (JSPWIKI-695) change note gets sticked upon several revisions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/JSPWIKI-695?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:all-tabpanel ] Juan Pablo Santos Rodr=C3=ADguez resolved JSPWIKI-695. ------------------------------------------------- Resolution: Fixed Fix Version/s: 3.0 fixed in v.3.0.0-svn-230, with it's corresponding unit test. ContentManager stores the change note as a page attribute. When saving a ne= w version of the page, it retrieves the last version, getting all of it's a= ttributes through a for loop.=20 As a consequence, if there wasn't a change note, we were storing the old ch= angenote in the new page's version. > change note gets sticked upon several revisions > ----------------------------------------------- > > Key: JSPWIKI-695 > URL: https://issues.apache.org/jira/browse/JSPWIKI-695 > Project: JSPWiki > Issue Type: Bug > Components: Core & storage > Affects Versions: 3.0 > Reporter: Juan Pablo Santos Rodr=C3=ADguez > Fix For: 3.0 > > > Reproduction steps: > - Create a new page and some content with a change note (for example rev1= ) > - Edit this new page with some more content, but without change note > - In the history table on Info tab, you can see the first version with it= 's associated change note, and the second version with the same change note > - If you edit once more the page with a new change note, this third revis= ion will show up it's associated change note > - Editing the page and saving again without change note will reflect the = bug again. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira