incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Janne Jalkanen <janne.jalka...@ecyrd.com>
Subject Re: [jira] [Resolved] (JSPWIKI-636) Clean unit test builds
Date Thu, 05 May 2011 13:29:19 GMT

Whee!

Awesome, thanks heaps :-)

/Janne

On 27 Apr 2011, at 17:36, Juan Pablo Santos Rodríguez (JIRA) wrote:

> 
>     [ https://issues.apache.org/jira/browse/JSPWIKI-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
> 
> Juan Pablo Santos Rodríguez resolved JSPWIKI-636.
> -------------------------------------------------
> 
>    Resolution: Fixed
> 
> Fixed DefaultAclManagerTest.testPrintAcl(). Saving pages involves calling RenderingManager.getRenderedDocument(),
which can return cached or non-cached WikiDocuments. 
> 
> In the first case, ACLs were not associated to current WikiPage, whereas in the second
one yes (DefaultAclManager.parseAcl() is called as part of MarkupParser.parse()).
> 
> Also, 27 tests where locale-dependant (test assertions assumed english locale), so TestEngine
and WikiContextFactory enforce it when building mock requests.
> 
>> Clean unit test builds
>> ----------------------
>> 
>>                Key: JSPWIKI-636
>>                URL: https://issues.apache.org/jira/browse/JSPWIKI-636
>>            Project: JSPWiki
>>         Issue Type: Test
>>         Components: Core & storage
>>   Affects Versions: Graduating
>>        Environment: All
>>           Reporter: Andrew Jaquith
>>           Assignee: Janne Jalkanen
>>           Priority: Blocker
>>            Fix For: Graduating
>> 
>> 
>> The current 3.0.0-svn trunk build has about 50+ failing unit tests. That isn't bad,
but we need a clean build before we graduate. Specific areas of focus are:
>> * ReferenceManager
>> * PageRenamer
>> * Index and Reference-related plugins
> 
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira


Mime
View raw message