incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Harry Metske <harry.met...@gmail.com>
Subject Re: [jira] Commented: (JSPWIKI-660) Support external properties in WikiEngine
Date Mon, 16 Aug 2010 19:37:15 GMT
Jürgen,

there is already a mechanism that allows you to specify the name of the
property file as a Java System property.
So for example for Tomcat you would first :
 export JAVA_OPTS=" -Djspwiki.propertyfile=/somedir/my.jspwiki.propfile "
and then start Tomcat, is that something you can use ?

There is also an advanced (or complex) system in place for handling cascaded
properties and variable substitution, is that something you can use ?
See:
http://people.apache.org/~metskem/JSPWiki-2.8/javadoc/com/ecyrd/jspwiki/PropertyReader.html


I think we should not make property handling much more complex than it is
now.
I propose we take Janne's proposal and make some minor changes to the
TextUtil.get*Property()
methods.

regards,
Harry


2010/8/16 Jürgen Weber (JIRA) <jira@apache.org>

>
>    [
> https://issues.apache.org/jira/browse/JSPWIKI-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898837#action_12898837]
>
> Jürgen Weber commented on JSPWIKI-660:
> --------------------------------------
>
> Another option is to just take jspwiki.properties out of the .war into a
> config folder, e.g. tomcat/conf/apps/jspwiki/jspwiki.properties
> So they are easily changeable.
> To change properties, you leave the default properties unchanged and put
> your overriding properties at the end of jspwiki.properties
> See
> http://www.mail-archive.com/users@tomcat.apache.org/msg77339.html
>
>
>
> > Support external properties in WikiEngine
> > -----------------------------------------
> >
> >                 Key: JSPWIKI-660
> >                 URL: https://issues.apache.org/jira/browse/JSPWIKI-660
> >             Project: JSPWiki
> >          Issue Type: Improvement
> >          Components: Core & storage
> >            Reporter: John McKinney
> >            Priority: Minor
> >
> > It would be nice if we could override the properties currently specified
> in jspwiki.properties from System.properties.  This would allow the ability
> to have templates, skins and some configuration external to core jspwiki
> making upgrading a much easier proposition.
> > I'd suggest something simple such as replacing:
> > m_templateDir    = TextUtil.getStringProperty( props, PROP_TEMPLATEDIR,
> "default" );
> > in WikiEngine with something like:
> > m_templateDir    = TextUtil.getStringProperty( System.getProperties(),
> PROP_TEMPLATEDIR, TextUtil.getStringProperty( props, PROP_TEMPLATEDIR,
> "default" ));
> > For all properties defined in jspwiki.properties
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message