incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Janne Jalkanen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JSPWIKI-649) CachingProvider.deleteVersion leaves a stale m_historyCache
Date Thu, 06 May 2010 05:25:47 GMT

    [ https://issues.apache.org/jira/browse/JSPWIKI-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864652#action_12864652
] 

Janne Jalkanen commented on JSPWIKI-649:
----------------------------------------

Deleting versions has never really worked - JSPWiki assumes that version histories are "not
gappy". Using deleteVersion() is definitely not recommended (and should be actually commented
in the source code as such, but it's not.)

You could get your desired behaviour by creating a new page, then deleting the old one (including
all of the version history), then copying it back with rename().

> CachingProvider.deleteVersion leaves a stale m_historyCache
> -----------------------------------------------------------
>
>                 Key: JSPWIKI-649
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-649
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Core & storage
>    Affects Versions: 2.8.3, 2.8.4
>         Environment: Ubuntu, Sun Java 1.6
>            Reporter: Magnus Lindberg
>            Priority: Minor
>         Attachments: jira-jspwiki-cachingprovider-patch.txt
>
>
> Hi JSPWiki developers,
> The function
>   public void deleteVersion( String pageName, int version )
> in class CachingProvider does not always update the page history cache appropriately.
> As a result, NoSuchVersionException:s can be thrown, if it's later assumed that a page
exists,
> because it's present in the (cached) history list.
> Below patch should fix the bug. (Works for me.)
> Regards, Magnus
> <pre>
> Index: src/com/ecyrd/jspwiki/providers/CachingProvider.java
> ===================================================================
> --- src/com/ecyrd/jspwiki/providers/CachingProvider.java	(revision 938415)
> +++ src/com/ecyrd/jspwiki/providers/CachingProvider.java	(working copy)
> @@ -815,10 +815,10 @@
>              {
>                  m_cache.removeEntry( pageName );
>                  m_textCache.removeEntry( pageName );
> -                m_historyCache.removeEntry( pageName );
>              }
>  
>              m_provider.deleteVersion( pageName, version );
> +            m_historyCache.removeEntry( pageName );
>          }
>      }
> </pre>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message