Mailing-List: contact jspwiki-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jspwiki-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of andrew.r.jaquith@gmail.com
 designates 209.85.221.193 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=tg910FKv6B6dWArJhUXke9Mo+yaa9kRfaiRnW2kOzPk0etAQgexUyKdWqjMIEiVFgs
         lduChgiGyXHTUpZ8/XETPk5T6XUvF91RUCdeIOs/AMOm4+YMfJb9ib+CiSFtTI04LSW1
         sgqTkP9RYik6EEBstuAqT6TNcPL9FwBoAx5Xw=
MIME-Version: 1.0
In-Reply-To: <3a6c97f01003061032i775d4dc1j6067fda21d93576d@mail.gmail.com>
References: <b90102161003060911v6c6bcc45i8d6817bef0ed50e1@mail.gmail.com>
	 <3a6c97f01003061032i775d4dc1j6067fda21d93576d@mail.gmail.com>
Date: Sat, 6 Mar 2010 14:25:36 -0500
Message-ID: <b90102161003061125k33dbbf84p652adce770f6fc0@mail.gmail.com>
Subject: Re: Removal of old UrlConstructors, WikiServlet
From: Andrew Jaquith <andrew.r.jaquith@gmail.com>
To: jspwiki-dev@incubator.apache.org
Content-Type: text/plain; charset=UTF-8

Ok -- checked it all in. I should have also mentioned that SpamFilter
was also essentially dead code -- everything in it was already done
(better) by the content-inspection stack. So I eliminated that too.

Janne and Dirk -- this checkin also implements the fixes to the JSPs
that allow editors to specify their own resources. Dirk, we will
probably want to make some adjustments to your (new) wysiwyg.jsp; I've
made some preliminary tweaks that you should take a look at. I'm happy
to help tweak the editor JSP and/or EditActionBean to make it work
nicely.

Andrew

On Sat, Mar 6, 2010 at 1:32 PM, Harry Metske <harry.metske@gmail.com> wrote:
> go ahead Andrew, "make my day" :-)
>
> regards,
> Harry
>
> 2010/3/6 Andrew Jaquith <andrew.r.jaquith@gmail.com>
>
>> All --
>>
>> I'm about to check in a batch of code. In it, I remove the
>> Short/ShortView URLConstructors. These aren't used any longer because
>> of the switch to StripesURLConstructor, which works identically to
>> DefaultURLConstructor.
>>
>> Also: the DefaultUrlConstructor is merged into StripesUrlConstructor
>> (quite easy, really). The URLConstructor interface method parsePage()
>> is removed, also, because that is taken care of by the framework.
>> (It's also not really a "constructor" method...)
>>
>> And, as a consequence, WikiServlet is also not needed. Its primary
>> function was to help decode short URLs, but that's done by
>> ShortUrlFilter now.
>>
>> Any objections before I commit? Nothing breaks, no real changes other
>> than removal of dead code.
>>
>> Andrew
>>
>