incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Janne Jalkanen <janne.jalka...@ecyrd.com>
Subject Re: Removal of old UrlConstructors, WikiServlet
Date Sun, 07 Mar 2010 13:34:50 GMT

No problems, but I would expect a bit longer than 2 hrs of warning for large code removals,
esp. considering timezones. If you're uncertain, I recommend a JIRA issue and a patch for
review and 72 hrs of review time.

/Janne

On 6 Mar 2010, at 19:11, Andrew Jaquith wrote:

> All --
> 
> I'm about to check in a batch of code. In it, I remove the
> Short/ShortView URLConstructors. These aren't used any longer because
> of the switch to StripesURLConstructor, which works identically to
> DefaultURLConstructor.
> 
> Also: the DefaultUrlConstructor is merged into StripesUrlConstructor
> (quite easy, really). The URLConstructor interface method parsePage()
> is removed, also, because that is taken care of by the framework.
> (It's also not really a "constructor" method...)
> 
> And, as a consequence, WikiServlet is also not needed. Its primary
> function was to help decode short URLs, but that's done by
> ShortUrlFilter now.
> 
> Any objections before I commit? Nothing breaks, no real changes other
> than removal of dead code.
> 
> Andrew


Mime
View raw message