incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Janne Jalkanen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JSPWIKI-578) Get rid of *.action URLs.
Date Wed, 20 Jan 2010 18:22:54 GMT

    [ https://issues.apache.org/jira/browse/JSPWIKI-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802921#action_12802921
] 

Janne Jalkanen commented on JSPWIKI-578:
----------------------------------------

I like option 2) better, 'cos 

a) it makes the default template "just another template", which means that it's fairly easy
to replace.
2) A well-crafted FileBasedActionResolver should be able to map multiple URLs to a single
ActionBean, allowing for full customizability which hasn't been possible before.

So IMO the idea behind this is NOT to get rid of JSPs as such, but to delegate them really
into their proper role: providing the templating engine.  Currently we're mixing the templating
engine with the C of MVC, which kinda is powerful, but it also results in lots of duplicated
code and makes everything fairly brittle.

And, we should still keep quite a few of the actual "action-oriented" JSP files such as rss.jsp
and SisterSites.jsp on the top-level. There's no point in turning those into templated files,
but the ActionResolver should be able to figure these out correctly.

So the aim is to essentially create a *single set* of JSP files where the View can be customized
far more freely than before, with the brittle Controller bit moved into ActionBeans, and the
WikiEngine providing the Model.  Currently in 3.0 the situation is kinda dumb 'cos we have
BOTH the ActionBeans and the top-level JSPs...  So I think that this should actually work
better for you, Murray - but if you've got any specific requirements in mind, please do let
us know! :-)

> Get rid of *.action URLs.
> -------------------------
>
>                 Key: JSPWIKI-578
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-578
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Core & storage, Default template
>            Reporter: Janne Jalkanen
>             Fix For: 3.0
>
>
> We currently have two URLs for each ActionBean - both the Wiki.jsp and Wiki.action are
available. Now, since the URLs are different, it has some nasty side-effects:
> * Users don't know which URL to bookmark, or they end up bookmarking both pages
> * Browsers don't know which pages are equal, and therefore both caching and page highlights
work inconsistently
> * Bots will index both pages, therefore giving odd results
> Since one of the design maxims of 3.0 is that URLs should not change, we should figure
out a way to get rid of the Stripes-induced *.action URLs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message