incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Jaquith (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JSPWIKI-578) Get rid of *.action URLs.
Date Sat, 16 Jan 2010 17:58:54 GMT

    [ https://issues.apache.org/jira/browse/JSPWIKI-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801241#action_12801241
] 

Andrew Jaquith commented on JSPWIKI-578:
----------------------------------------

There are two issues here:

1. The method you used, changing the @UrlBinding annotation in the class file, means that
URL bindings are hard-coded into the ActionBean. I wrote FileBasedActionResolver to allow
these to be externalized. So, when the time is right, that is the technique we should use
rather than marking up the source code file.

2. Using /Wiki.jsp as the URL binding creates a bit of a chicken-and-egg problem: when you
directly GET Wiki.jsp, the stripes:useActionBean tag fires, which executes the event "view".
That "view" event in turn forwards to.... Wiki.jsp. So I THINK the view method will execute
twice. Not exactly sure, but I remember there were some complications.

I don't think this needs to be done for graduation, but it needs to be done before the 3.0
beta. All of the other features need to work properly, e.g., AJAX... URL bindings should be
the last step.

Also -- per your previous comment from 25 July: it would be good to find the scripts that
output hard-coded URLs, and make those use URLConstructor or the UrlBindingFactory. When we
"throw the switch" and activate FileBasedActionResolver, anybody who wants to specify an arbitrary
URL scheme can do so.

> Get rid of *.action URLs.
> -------------------------
>
>                 Key: JSPWIKI-578
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-578
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Core & storage, Default template
>            Reporter: Janne Jalkanen
>             Fix For: 3.0
>
>
> We currently have two URLs for each ActionBean - both the Wiki.jsp and Wiki.action are
available. Now, since the URLs are different, it has some nasty side-effects:
> * Users don't know which URL to bookmark, or they end up bookmarking both pages
> * Browsers don't know which pages are equal, and therefore both caching and page highlights
work inconsistently
> * Bots will index both pages, therefore giving odd results
> Since one of the design maxims of 3.0 is that URLs should not change, we should figure
out a way to get rid of the Stripes-induced *.action URLs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message