incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harry Metske (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JSPWIKI-633) changenote and replaceEntities
Date Fri, 29 Jan 2010 17:20:34 GMT

    [ https://issues.apache.org/jira/browse/JSPWIKI-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806398#action_12806398
] 

Harry Metske commented on JSPWIKI-633:
--------------------------------------

I am a bit confused about what you are considering a bug.

Is it the replacement of {noformat}>{noformat} by {noformat}&gt;{noformat}  , or the
fact that we don't call ReplaceEntities during page rename ?

We do the replaceEntities for security reasons on input fields like changnote, where bad guys
coud stick in something like {noformat}<script>alert('XSS')</script>{noformat}

While renaming a page, you cannot enter a changenote or something else that contains user-supplied
input.
Can you describe what change you think is necessary ?

> changenote and replaceEntities
> ------------------------------
>
>                 Key: JSPWIKI-633
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-633
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Core & storage
>    Affects Versions: 2.8.3
>         Environment: Redhat Linux, Tomcat 6.0.16
>            Reporter: Stefan Bohn
>            Priority: Minor
>
> When editing a page, you can enter the changenote.
> Edit.jsp, Line 45:
> String changenote = TextUtil.replaceEntities( findParam( pageContext, "changenote" )
);
> RecentChangePlugin.java, Line 217
> row.addElement( new td(changenote != null ? TextUtil.replaceEntities(changenote) : "").setClass("changenote")
);
> So the entities of the text entered via Edit.jsp are replaced twice.
> PageRenamer.java Lines 139 and 206:
> p.setAttribute( WikiPage.CHANGENOTE, fromPage.getName()+" ==> "+toPage.getName() );
> TextUtil.replaceEntities is not called.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message