Mailing-List: contact jspwiki-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jspwiki-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of andrew.r.jaquith@gmail.com
 designates 209.85.221.172 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=N2jEOWlIAHBlxdtGt0BHSC4NsgLPTe0Yz/iQe60eg5XseKjL4P0VB3he6V9K4MIS1u
         tbdcWCfoRv1klCPG8edrqFoHsQ3IIq8j3IT8cFITkUpkwO78+tHAebknWmmev/iLtvRz
         7VbdLAL8Mes8t1NL937LC4xR2lqjVe5foz7jU=
MIME-Version: 1.0
In-Reply-To: <b90102160910171401n6fa05cddjf4ca1de4b2e72a3e@mail.gmail.com>
References: <b90102160910112148n7aa00710ibb781f250c477bf7@mail.gmail.com>
	 <10D7C175-3BC1-4375-BF0B-C208C3687504@ecyrd.com>
	 <D07EB827-E989-4E6F-B899-FA9599B61CE2@gmail.com>
	 <7EE4F3F7-8566-4B43-89BB-24C38FA1392F@ecyrd.com>
	 <b90102160910151101s505ae1bbi9814aef81c276979@mail.gmail.com>
	 <2DF4ED35-972A-4408-9FCB-9450D9F8D07C@ecyrd.com>
	 <b90102160910152006s38143b05jf1a4f6d590bb2a00@mail.gmail.com>
	 <b90102160910170919m4bcab429k4ef6cf96511853ac@mail.gmail.com>
	 <3E2CB175-D3EC-4E21-A5C6-18F3064DE152@ecyrd.com>
	 <b90102160910171401n6fa05cddjf4ca1de4b2e72a3e@mail.gmail.com>
Date: Sat, 17 Oct 2009 18:48:09 -0400
Message-ID: <b90102160910171548u60abcc7ax5b68f78464bc7288@mail.gmail.com>
Subject: Re: Page renaming weirdness
From: Andrew Jaquith <andrew.r.jaquith@gmail.com>
To: jspwiki-dev@incubator.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Fixed item 3. The translate() method in the JSPWikiMarkupParserTest
was simply creating nodes and not saving them, relying on pageExists()
to tell it if they had been created. But in 3.0 you can create a page
without saving it -- different than 2.x, where creating automatically
means the page is persisted. Forcing the page-save before the
rendering speed test fixed the problem.

Anyway, it was a bug in the test code, not the core code. All good!

Andrew

On Sat, Oct 17, 2009 at 5:01 PM, Andrew Jaquith
<andrew.r.jaquith@gmail.com> wrote:
>> I'm currently working on moves (the SNS support is really hard to do wit=
hout
>> screwing everything); I have something new on the hard drive already whi=
ch
>> may be fixing this.
>
> Excellent. I'll cool my jets on these until something new hits the Priha =
trunk.
>
>> This suggests a serious bug in JSPWiki, which is creating a new page *by=
 the
>> same name* as an existing page. Since JSPWiki currently is using
>> "nt:unstructured" as the page type, Priha will happily allow these so-ca=
lled
>> same-name-siblings - as specified by JCR spec.
>>
>> This functionality was turned off in 0.5.3, but it's enabled again in tr=
unk.
>> =A0However, in this case the test will pass but JSPWiki will not work
>> correctly.
>>
>> I think we should either switch the node type, or add an assertion for p=
ages
>> which already exist.
>
> Hmm. I haven't switched back the isNew() stuff in ContentManager just
> yet. I'll try that first. If it doesn't fix the problem, I'll add some
> existence-checking code into addPage().
>
> Andrew
>