Mailing-List: contact jspwiki-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jspwiki-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of harry.metske@gmail.com
 designates 209.85.218.227 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=mua760tDdja6+rzLXyaV3Gzos6kHs2634XYzXbc2Ejh2RumcoJWpjma201xXuTZyqB
         RAbaNSqb/6g89/8TnYQxtilMUbg4i7VQKbajDQizlvMfdwjXf9jbiBgYPuaRUpKUrzqj
         4tJNWmbVtiSEXF9gwOMv8EHfAvMRVc62R1FvU=
MIME-Version: 1.0
In-Reply-To: <8A60A2CC-2969-4B4B-93E6-E3E6A3BC3BA6@ecyrd.com>
References: <b90102160910112148n7aa00710ibb781f250c477bf7@mail.gmail.com>
	 <8A60A2CC-2969-4B4B-93E6-E3E6A3BC3BA6@ecyrd.com>
Date: Mon, 12 Oct 2009 15:42:55 +0200
Message-ID: <3a6c97f00910120642x33abedd2q442cf3a9093be93f@mail.gmail.com>
Subject: Re: Page renaming weirdness
From: Harry Metske <harry.metske@gmail.com>
To: jspwiki-dev@incubator.apache.org
Content-Type: multipart/alternative; boundary=00151758a67868a3b90475bd1b02

--00151758a67868a3b90475bd1b02
Content-Type: text/plain; charset=UTF-8

I almost checked in that priha version yesterday :-)
Should I wait, or commit that one in ?

I kept some test-stats BTW:
http://people.apache.org/~metskem/tests/jspwiki-testresult.html
(you can see the good results from Andrew's work the last few days)


regards,
Harry

2009/10/12 Janne Jalkanen <Janne.Jalkanen@ecyrd.com>

>
> Yup, this is a known problem in 0.3.2... Should be fixed in the current
> trunk.
>
> /Janne
>
>
> On Oct 12, 2009, at 07:48 , Andrew Jaquith wrote:
>
>  Janne, I'm digging into more bugs...
>>
>> The page-renamer tests haven't worked for  a while. I think I know why.
>>
>> ContentManager.renamePage(WikiContext, fromPage, toPage) has a bug.
>> Specifically, after this code executes:
>>
>>           getCurrentSession().move( getJCRPath( fromPage ),
>> getJCRPath( toPage ) );
>>           getCurrentSession().save();
>>
>> ...fromPage is still accessible after this point. I.e.,
>> engine.getPage(fromPage) returns a valid page. Moreover, it shares the
>> same JCR UUID as the toPage. That would suggest that something isn't
>> getting cleaned up properly inside of Priha SessionImpl.move().
>>
>> Of the 18 failing PageRenamerTest tests, fixing this bug would
>> probably get rid of 15 of them.
>>
>> Thoughts?
>>
>> Andrew
>>
>
>

--00151758a67868a3b90475bd1b02--