incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Florian Holeczek <flor...@holeczek.de>
Subject Re: Priha shutdown
Date Mon, 26 Oct 2009 08:10:58 GMT
Hi Andrew,

just a few quick notes without having looked into the code...

> Just checked 0.5.5 in. The shutdown() method works as advertised -- thanks!

Just like with SQL, such methods aren't in the JCR standard. Do we check
 whether we're really using Priha while calling this method?

> One thing I've noticed in recent Priha builds is that it checks for a
> lockfile to ensure exclusive use. That is a good idea, but it's meant
> I had to hunt down and kill a few stray WikiEngine references in unit
> tests that didn't call WikiEngine.shutdown(). Easily done once I knew
> what to look for.

Hmm, doesn't that sound like using a singleton would be the way to go?

Regards
 Florian

Mime
View raw message