incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Harry Metske <harry.met...@gmail.com>
Subject Re: Page renaming weirdness
Date Wed, 14 Oct 2009 19:25:47 GMT
Yep, very nice, thanks a lot !
/Harry

2009/10/13 Andrew Jaquith <andrew.r.jaquith@gmail.com>

> That seems to work a LOT better -- thanks!
>
> On Tue, Oct 13, 2009 at 2:32 AM, Janne Jalkanen
> <Janne.Jalkanen@ecyrd.com> wrote:
> >
> > Done; 0.5.3 should fix this.
> >
> > /Janne
> >
> > On Oct 13, 2009, at 06:22 , Andrew Jaquith wrote:
> >
> >> Yeah, unfortunately 0.5.2 is even worse than 0.5.0. 39 failures, 57
> >> errors.
> >>
> >> That said, MANY of them seem to be IllegalStateExceptions related to
> >> dates, e.g.,:
> >>
> >> java.lang.IllegalStateException
> >> at org.priha.core.values.ValueImpl.checkValue(ValueImpl.java:63)
> >> at
> >>
> org.priha.core.values.CalendarValueImpl.getDate(CalendarValueImpl.java:101)
> >> at
> >>
> org.priha.core.values.ValueFactoryImpl.createValue(ValueFactoryImpl.java:71)
> >> at
> >>
> org.priha.core.values.ValueFactoryImpl.cloneValue(ValueFactoryImpl.java:337)
> >> at org.priha.providers.ValueContainer.deepClone(ValueContainer.java:144)
> >> at org.priha.core.PropertyImpl.getValue(PropertyImpl.java:188)
> >> at org.priha.core.PropertyImpl.getValue(PropertyImpl.java:40)
> >> at
> >>
> org.apache.wiki.content.ContentManager.copyProperties(ContentManager.java:428)
> >> at
> org.apache.wiki.content.ContentManager.checkin(ContentManager.java:392)
> >> at org.apache.wiki.content.ContentManager.save(ContentManager.java:465)
> >> at
> >>
> org.apache.wiki.parser.JSPWikiMarkupParser.handleAccessRule(JSPWikiMarkupParser.java:1417)
> >> at
> >>
> org.apache.wiki.parser.JSPWikiMarkupParser.handleHyperlinks(JSPWikiMarkupParser.java:1499)
> >> at
> >>
> org.apache.wiki.parser.JSPWikiMarkupParser.handleOpenbracket(JSPWikiMarkupParser.java:2320)
> >> at
> >>
> org.apache.wiki.parser.JSPWikiMarkupParser.parseToken(JSPWikiMarkupParser.java:2899)
> >> at
> >>
> org.apache.wiki.parser.JSPWikiMarkupParser.fillBuffer(JSPWikiMarkupParser.java:2695)
> >> at
> >>
> org.apache.wiki.parser.JSPWikiMarkupParser.parse(JSPWikiMarkupParser.java:2971)
> >> at
> >>
> org.apache.wiki.render.RenderingManager.getRenderedDocument(RenderingManager.java:247)
> >> at
> >>
> org.apache.wiki.render.RenderingManager.getHTML(RenderingManager.java:323)
> >> at org.apache.wiki.WikiEngine.textToHTML(WikiEngine.java:1543)
> >> at
> >>
> org.apache.wiki.content.ContentManager$SaveWikiPageTask.execute(ContentManager.java:1267)
> >> at
> org.apache.wiki.workflow.Workflow.processCurrentStep(Workflow.java:766)
> >> at org.apache.wiki.workflow.Workflow.start(Workflow.java:681)
> >> at
> org.apache.wiki.workflow.WorkflowManager.start(WorkflowManager.java:82)
> >> at org.apache.wiki.WikiEngine.saveText(WikiEngine.java:1775)
> >> at org.apache.wiki.TestEngine.saveText(TestEngine.java:379)
> >> at
> >>
> org.apache.wiki.auth.AuthorizationManagerTest.testPrincipalAcl(AuthorizationManagerTest.java:466)
> >>
> >>
> >> The file-renaming bugs seem to have been partly fixed, although there
> >> are still errors (might be in the calling code, though).
> >>
> >> Andrew
> >>
> >> On Mon, Oct 12, 2009 at 9:42 AM, Harry Metske <harry.metske@gmail.com>
> >> wrote:
> >>>
> >>> I almost checked in that priha version yesterday :-)
> >>> Should I wait, or commit that one in ?
> >>>
> >>> I kept some test-stats BTW:
> >>> http://people.apache.org/~metskem/tests/jspwiki-testresult.html
> >>> (you can see the good results from Andrew's work the last few days)
> >>>
> >>>
> >>> regards,
> >>> Harry
> >>>
> >>> 2009/10/12 Janne Jalkanen <Janne.Jalkanen@ecyrd.com>
> >>>
> >>>>
> >>>> Yup, this is a known problem in 0.3.2... Should be fixed in the
> >>>> current
> >>>> trunk.
> >>>>
> >>>> /Janne
> >>>>
> >>>>
> >>>> On Oct 12, 2009, at 07:48 , Andrew Jaquith wrote:
> >>>>
> >>>> Janne, I'm digging into more bugs...
> >>>>>
> >>>>> The page-renamer tests haven't worked for  a while. I think I know
> >>>>> why.
> >>>>>
> >>>>> ContentManager.renamePage(WikiContext, fromPage, toPage) has a bug.
> >>>>> Specifically, after this code executes:
> >>>>>
> >>>>>         getCurrentSession().move( getJCRPath( fromPage ),
> >>>>> getJCRPath( toPage ) );
> >>>>>         getCurrentSession().save();
> >>>>>
> >>>>> ...fromPage is still accessible after this point. I.e.,
> >>>>> engine.getPage(fromPage) returns a valid page. Moreover, it shares
> >>>>> the
> >>>>> same JCR UUID as the toPage. That would suggest that something isn't
> >>>>> getting cleaned up properly inside of Priha SessionImpl.move().
> >>>>>
> >>>>> Of the 18 failing PageRenamerTest tests, fixing this bug would
> >>>>> probably get rid of 15 of them.
> >>>>>
> >>>>> Thoughts?
> >>>>>
> >>>>> Andrew
> >>>>>
> >>>>
> >>>>
> >>>
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message