Mailing-List: contact jspwiki-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jspwiki-dev@incubator.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Subject: RE: ReCaptcha?
Date: Fri, 18 Sep 2009 15:57:08 +0200
Message-ID: 
 <B239B3B087CDEA4AADF456184749E792018A5F0F@MCHP7IEA.ww902.siemens.net>
In-Reply-To: <A126FA04-A54C-421C-8291-99C683772A5B@gmail.com>
Thread-Topic: ReCaptcha?
Thread-Index: Aco4ZlinZBofVA+BQ0m5e2OjoDQelwAAVioQ
References: <b90102160909161331u471ed1e1j349490512cd005d9@mail.gmail.com>
 <0AD5A834-C1BF-4713-A70D-5394F58E713B@ecyrd.com>
 <0715D713-AB6A-48E3-AD80-666E8CF23EAA@gmail.com>
 <B239B3B087CDEA4AADF456184749E792018A5E12@MCHP7IEA.ww902.siemens.net>
 <A126FA04-A54C-421C-8291-99C683772A5B@gmail.com>
From: "Dalen, Andre van" <andre.van.dalen@siemens.com>
To: <jspwiki-dev@incubator.apache.org>


Ah, The way I read your text I envisioned the Inspector's to be=20
plugins into the SpamFilter adding an extra layer of configuration.

-----Original Message-----
From: Andrew Jaquith [mailto:andrew.r.jaquith@gmail.com]=20
Sent: vrijdag 18 september 2009 15:45
To: jspwiki-dev@incubator.apache.org
Subject: Re: ReCaptcha?

I haven't committed to doing this just yet; I'm being careful not to =20
step on Jannes's toes, because he wrote the SpamFilter code, and I =20
want his input before I go too much further.

But yes, I agree that if we were to rework the code, moving the =20
messages into bundles would be good. I find the messages a bit cheeky =20
also, and it would be nice to be able to customize them.

The basic idea you described (splitting the SpamFilter into smaller =20
chunks) is what I had in mind for the refactoring. This is what I =20
meant by the reference to a series of new stackable "Inspector" classes.

Andrew

On Sep 18, 2009, at 8:23, "Dalen, Andre van"
<andre.van.dalen@siemens.com=20
 > wrote:

>
> Hi Andrew,
>
> Looks like you also could split the combined filter into a few more
> basic
> filters and let the JSPWiki take care of combining them.
> (i.e. a chapta filer, spamwords filter, externallinks filter, number =20
> of
> edits filter, etc.)
>
> While you're at it, could you have a look at making the messages
> configurable?
> I have been confronted by users that did not like the tongue-in-cheek
> messages telling them they could not do what they wanted because of =20
> some
> Herb :-)
>
> I ended up hiding the SpamFilter in a closed collapsebox because of =20
> it.
>
>    regards, Andre
>
> -----Original Message-----
> From: Andrew Jaquith [mailto:andrew.r.jaquith@gmail.com]
> Sent: vrijdag 18 september 2009 14:13
> To: jspwiki-dev@incubator.apache.org
> Cc: jspwiki-dev@incubator.apache.org
> Subject: Re: ReCaptcha?
>
> Good points. I do think it makes sense to have a reCaptcha option
> among others that might arise.
>
> On a side note, I'm fooling around with SpamFilter to make it a lot
> more extensible. I have this idea about stackable "Inspector" objects
> that extract the current (rather complex) logic into separate
> implementions, but which collaborate on the outcome. The driver for
> this was the need to have better integration with the view layer and
> additional captcha systems.
>
> I'll run the design by you when it firms up, but my initial
> experiments look very promising. I think you'll like it a lot.
>
> Andrew
>
> On Sep 16, 2009, at 17:21, Janne Jalkanen <Janne.Jalkanen@ecyrd.com>
> wrote:
>
>>
>> Google is well known for their embrace and extinguish -tactic. It
>> would be unlikely that ReCaptcha will get any new development.
>>
>> The captcha system we have is designed to be pluggable, so it should
>> be possible to add other systems as well. More the merrier; then we
>> won't be subject to corporate whims...
>>
>> /Janne
>>
>> On Sep 16, 2009, at 23:31 , Andrew Jaquith wrote:
>>
>>> Any thoughts on ReCaptcha? Google just bought them. I thought this
>>> might be a nice addition to what we offer now (Asirra) -- maybe
>>> even a
>>> replacement for it.
>>>
>>> Andrew
>>