incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Janne Jalkanen <janne.jalka...@ecyrd.com>
Subject Re: PageViewPlugin
Date Sun, 09 Aug 2009 11:51:44 GMT

*grin* Should've skimmed it more accurately then!

/Janne

On 9 Aug 2009, at 12:20, Harry Metske wrote:

> that is also already in the code :-)
>
> 2009/8/9 Janne Jalkanen <janne.jalkanen@ecyrd.com>
>
>>
>> An improvement would be that it could also listen to the
>> WikiEngineEvent.SHUTDOWN to be on the safe side.
>>
>> Is Andre on this list?  Would you mind contributing your code to us?
>>
>> /Janne
>>
>>
>> On 9 Aug 2009, at 11:59, Harry Metske wrote:
>>
>> the plugin spawns a separate thread when it first initializes  
>> (using a
>>> static var).The thread saves the in-memory counts to a file each 5
>>> minutes.
>>>
>>> Harry
>>>
>>> 2009/8/9 Florian Holeczek <florian@holeczek.de>
>>>
>>> Hi all,
>>>>
>>>> I don't believe either it would be too late to integrate in 2.8,  
>>>> since
>>>>> it would be just a new plugin and does not change existing APIs  
>>>>> in any
>>>>> way.
>>>>>
>>>>
>>>> ok, fine then! :-) Was thinking of the policy to only integrate  
>>>> bugfix
>>>> code into a stable branch, but indeed, it's a non-invasive change.
>>>>
>>>> (Note, however, that there's still a good reason to store page view
>>>>> counts in a separate file: performance. Having a database write
>>>>> (possibly several) for each read would be very heavy.  Better to
>>>>> journal it and keep a latest count in memory; then upon startup  
>>>>> read
>>>>> the journal back in.  JCR does not have the concept of appending  
>>>>> to a
>>>>> Property either.)
>>>>>
>>>>
>>>> AFAIK this is just the way Andre has implemented it :-)
>>>>
>>>> regards
>>>> Florian
>>>>
>>>>
>>


Mime
View raw message