Mailing-List: contact jspwiki-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jspwiki-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of andrew.r.jaquith@gmail.com
 designates 209.85.219.172 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:from:to:in-reply-to:content-type
         :content-transfer-encoding:x-mailer:mime-version:subject:date
         :references;
        b=l5uOcYTRwrtaRDiJo0qcKZr2TABsLzL6o9+a59Gtgz6UZAuQOObdME1efQoB/GCD2S
         MyCC+CNYW6ynVTkl3Si51U/HIoucN452m2icokQxta1OTEDEEZNLR84RhaAa1ImImKqz
         akTmyLzT6OIPAoZL3IaOODeSSUJMYFjlDnO4c=
Message-Id: <273B8ED9-6A6D-4922-99DB-ACC0392E911E@gmail.com>
From: Andrew Jaquith <andrew.r.jaquith@gmail.com>
To: JSPWiki developers <jspwiki-dev@incubator.apache.org>
In-Reply-To: <01DD91F8-E431-4AFD-8B5B-290295E9FAE8@ecyrd.com>
Content-Type: text/plain;
	charset=us-ascii;
	format=flowed;
	delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (iPhone Mail 5H11)
Subject: Re: WikiContext switcheroos in Tag classes
Date: Fri, 22 May 2009 04:57:39 -0500
References: <b90102160905201711l7344b1c2k8a20672e8bff218b@mail.gmail.com>
 <65502736-5288-4C79-B8EA-BF0782C00338@ecyrd.com>
 <b90102160905211103t54569669le4c86c9a04df6166@mail.gmail.com>
 <01DD91F8-E431-4AFD-8B5B-290295E9FAE8@ecyrd.com>

HAH! I found the bastard. It's a cloning issue. WikiActionBeanContext  
wasn't cloning it's delegate DefaultWikiContext.

Anyway, while I was at it, I refactored all of the iterator tags,  
whacking about 2/3 of the code (rampant cut-n-paste jobs). What I'll  
check in later will be lean, clean and documented. :)

Andrew

On May 21, 2009, at 14:20, Janne Jalkanen <janne.jalkanen@ecyrd.com>  
wrote:

>
> It's likely that there is overlap in these techniques :-)
>
> /janne, typing one-handedly
>
> On 21 May 2009, at 21:03, Andrew Jaquith wrote:
>
>>> My guess is that some of your other modifications are causing  
>>> problems with
>>> the page names - on 2.8.x, the AttachmentsIteratorTag seems to be  
>>> working
>>> perfectly.  Or maybe I misunderstood your problem?
>>
>> Yep, no question about it. Something isn't working as intended. I'll
>> need to dig a bit to figure out what's going on. I'm going to be
>> looking at a few issues: when m_wikiContext is actually changed; when
>> ATTR_WIKICONTEXT is set, and when WikiContext.setPage() is called.  
>> Any
>> of these three activities could be where the problem lies.
>>
>> Andrew
>