incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Jaquith <andrew.r.jaqu...@gmail.com>
Subject Re: JUnit testing 3.0 => pagename prepend with Main: ?
Date Sat, 11 Apr 2009 11:44:25 GMT
I'd like Janne's take on this, but changing the tests to include the  
prepended space name sounds like a good idea to me.

On a related note: I am considering changing the method name  
WikiPage.getQualifiedName() to .getWikiName(). Makes more sense. Any  
objections?

Andrew

On Apr 10, 2009, at 13:27, Harry Metske <harry.metske@gmail.com> wrote:

> I started to dig into the JUnit tests that are failing, starting with
> WikiEngineTest.
> I noticed that many tests fail because the pageName returned is  
> prepended
> with "Main:".
> For example:
>
> *assertEquals( "plural mistake", "Foobars", m_engine.getFinalPageName(
> WikiName.valueOf("Foobars") ) );*
>
> The test can be changed to make it succeed by changing it to :
>
> *assertEquals( "plural mistake", "Main:Foobars",  
> m_engine.getFinalPageName(
> WikiName.valueOf( "Foobars" ) ).toString() );*
>
> Is that the correct fix ?
>
> Harry

Mime
View raw message