incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Kable <>
Subject Re: [jira] Commented: (JSPWIKI-526) Allow administrators to select the Comparator used for sorting page lists by name
Date Wed, 29 Apr 2009 04:40:52 GMT
Janne Jalkanen (JIRA) wrote:
> Greg, can you also port this to SVN trunk, please?

Sure but it will be a little while before I get time to do it.  before I 
even start, I have two questions for the developers:

1) The default template has a piece of JavaScript which pops up a list
of matching pages as you type a link but the list is unordered.  I'd
like to order it but I can't figure out where it's getting the list. 
Does anybody know?

2) I've noticed lot's of cases where page lists are repacked and
resorted multiple times because the APIs return only Collection so the 
developer has played it safe and repacked into something they know. 
Before I port the sorting patch, I'd like to go through all APIs that 
return collections of pages and make them return a standard, concrete 
class - HashSet for unordered collections, TreeSet for ordered 
collections.  The big disadvantage of doing this is that we can no 
longer change the Collection used by the APIs - they are now frozen. 
Two big advantages are a much clearer understanding of what's going on 
and some opportunity to optimise behaviour because we know and can rely 
on the underlying implementation.  It will also give me a chance to get 
familiar with 3.x.  Any opinions?


View raw message