incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Kable (JIRA)" <j...@apache.org>
Subject [jira] Updated: (JSPWIKI-528) Rationalise the use of Collections, particularly with regard to pages
Date Thu, 30 Apr 2009 11:52:30 GMT

     [ https://issues.apache.org/jira/browse/JSPWIKI-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Greg Kable updated JSPWIKI-528:
-------------------------------

    Attachment: jspwiki-528-SearchProviders.patch

Patch 3 - org.apache.wiki.search.

- Changed BasicSearchProvider, LuceneSearchProvider and SearchProvider to return an ordered
List and updated Javadoc to match.  Why List instead of SortedSet you ask? In this case using
SortedSet would require repacking and re-ordering results from 3rd party search engines (e.g.
Lucene) whereas List simply preserves the underlying order.

> Rationalise the use of Collections, particularly with regard to pages
> ---------------------------------------------------------------------
>
>                 Key: JSPWIKI-528
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-528
>             Project: JSPWiki
>          Issue Type: Improvement
>            Reporter: Greg Kable
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: jspwiki-528-AttachmentHandler.patch, jspwiki-528-LinkCollector.patch,
jspwiki-528-SearchProviders.patch
>
>
> Most of the APIs return Collection rather than a finer interface and in many cases these
collections are repeatedly repacked and resorted unnecessarily. I will go through all APIs
that return collections of pages and make them return a finer interface - probably List for
unordered collections and SortedSet for ordered collections. This will make the use of these
collections much clearer for further development and give us some opportunity for future optimisations.
> This is likely to be a very wide set of changes across lots of different classes so I'll
submit separate patches for each class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message