incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Kable (JIRA)" <>
Subject [jira] Updated: (JSPWIKI-528) Rationalise the use of Collections, particularly with regard to pages
Date Thu, 30 Apr 2009 11:20:30 GMT


Greg Kable updated JSPWIKI-528:

    Attachment: jspwiki-528-AttachmentHandler.patch

Patch number two - AttachmentManager.

- Changed the return type of listAttachments to List<WikiPage>
- Added a new method - SortedSet<WikiPage> listAttachmentsSorted which returns a sorted
set of attachments
- Changed hasAttachments to be more efficient

> Rationalise the use of Collections, particularly with regard to pages
> ---------------------------------------------------------------------
>                 Key: JSPWIKI-528
>                 URL:
>             Project: JSPWiki
>          Issue Type: Improvement
>            Reporter: Greg Kable
>            Priority: Minor
>             Fix For: 3.0
>         Attachments: jspwiki-528-AttachmentHandler.patch, jspwiki-528-LinkCollector.patch
> Most of the APIs return Collection rather than a finer interface and in many cases these
collections are repeatedly repacked and resorted unnecessarily. I will go through all APIs
that return collections of pages and make them return a finer interface - probably List for
unordered collections and SortedSet for ordered collections. This will make the use of these
collections much clearer for further development and give us some opportunity for future optimisations.
> This is likely to be a very wide set of changes across lots of different classes so I'll
submit separate patches for each class.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message