incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Janne Jalkanen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JSPWIKI-498) Performance Issues with Lucene Index
Date Tue, 10 Feb 2009 20:37:59 GMT

    [ https://issues.apache.org/jira/browse/JSPWIKI-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672391#action_12672391
] 

Janne Jalkanen commented on JSPWIKI-498:
----------------------------------------

I see at least the following problems with this patch:

* SearchMatcher.notAuthorized() is not localized.
* The patch does not adhere to JSPWiki coding guidelines (e.g. the use of tabs instead of
spaces, curly braces and so on)
* I don't understand why SearchMatcher needs to be augmented with a new routine breaking binary
and source compatibility (big no-no for patch releases)
* WikiEngine.findPages(String,int,int) should be in SearchManager.
* LuceneSearchProvider is relicensed under LGPL
* There is a dependency to PDFBox (this should be a separate issue and patch)
* Generics are replaced with non-generics (undoing the work we did for 2.8)
* Some old bugs are reintroduced by failing to catch exceptions properly
* There is some strange "owiki.tld" being included in AjaxSearch.jsp
* The patch is way too big to be examined properly - there are lots of changes to AjaxSearch.jsp
for example, most of look like reindentation.

All in all, a strong -1 from me for this patch.  Please clean it up and make it really short
and sweet so that it can be properly reviewed.

> Performance Issues with Lucene Index
> ------------------------------------
>
>                 Key: JSPWIKI-498
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-498
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Default template
>    Affects Versions: 2.8.1
>         Environment: Win 2003 on XEN-Server, 3 GB RAM, 4 x Intel Xeon 2Ghz
>            Reporter: Kurt Stein
>         Attachments: patch_lucene_search.txt, screenshot-1.jpg
>
>
> Our Wiki-Luceneindex has swollen to 33 MB and if someone searches words like "find" he
gets about 500 results. Only problem is, it takes about 30 seconds to complete the search.
> I have looked a bit into the problem and there is something strange to me. JSPWiki searches
twice every query. 
> Once in search.jsp and afterwards in AjaxSearch.jsp.
> The filteredList from search.jsp is written to the pagecontext but this information is
never read within the AjaxSearch.jsp. Thus AjaxSearch.jsp makes a second search.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message