Mailing-List: contact jspwiki-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jspwiki-dev@incubator.apache.org
Message-ID: <155412347.1230842744690.JavaMail.jira@brutus>
Date: Thu, 1 Jan 2009 12:45:44 -0800 (PST)
From: "Harry Metske (JIRA)" <jira@apache.org>
To: jspwiki-dev@incubator.apache.org
Subject: [jira] Commented: (JSPWIKI-464) JSPWiki authentication support for
 TextOutputCallback (display login messages on Login.jsp)
In-Reply-To: <1012742238.1230579884177.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/JSPWIKI-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660230#action_12660230 ] 

Harry Metske commented on JSPWIKI-464:
--------------------------------------

it's even simpler, have a look at the code snippet, it is just checking

if( !name.startsWith(Constants.JSP_PACKAGE_NAME) )

and Constants.JSP_PACKAGE_NAME has the value org.apache.jsp (with no
trailing dot).

Any good suggestions for our new package names :-)

I can file a separate JIRA for this issue.

regards,
Harry

2009/1/1 Janne Jalkanen (JIRA) <jira@apache.org>


> JSPWiki authentication support for TextOutputCallback (display login messages on Login.jsp)
> -------------------------------------------------------------------------------------------
>
>                 Key: JSPWIKI-464
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-464
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Authentication&Authorization
>    Affects Versions: 3.0
>         Environment: JSPWiki 3.0
>            Reporter: Harry Metske
>            Assignee: Harry Metske
>            Priority: Minor
>         Attachments: JSPWIKI-464.patch, jspwiki-login-3.0.patch
>
>
> The current version of the JSPWiki JAAS implementation does not support TextOutputCallback's.
> JAAS offers several types of Callbacks, JSPWiki's CallbackHandler currently only uses the NameCallback and PasswordCallback.
> As a result the following scenario:
> Users try to login, the login fails but the user is not told for what reason.
> I have had lots of complaints about this behavior, especially from users who do not login very often but use the wiki mostly for reading.
> When they try to login, it fails, but the Login.jsp does not tell anything at all, not even that is has failed (C.M.A.). 
> In most cases because either the userid has become inactive, is revoked, or the password is expired. The net effect is that the wiki is often not usable for updates.
> Now I know that giving this information (the failure reason) to the user is often considered a security trade off.
> But in an intranet environment this is very acceptable.
> I will attach a patch that solves this in the following way :
> - AuthenticationManager keeps a Hashtable of last loginMessages for each user.
> - The WikiCallbackHandler now also handles TextOutputCallbacks and sets the login result
> - If the login fails, the LoginActionBean first reads the loginMessage for the user, if it is not null, it is displayed, else you get the old behavior.
> The exploitation of TextOutputCallbacks is optional, the default LoginModule (supplied with JSPWiki) does not use them, and therefore it's behavior is unchanged. 
> The installer has to supply a LoginModule that uses the TextOutputCallback to store the loginResult.  (And off course we have one that uses it).
> (Andrew), can we take this patch in the trunk ?
> regards,
> Harry

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.