incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harry Metske (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JSPWIKI-452) JMX implementation does not support More than one JSPWiki instance
Date Fri, 02 Jan 2009 17:51:44 GMT

    [ https://issues.apache.org/jira/browse/JSPWIKI-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660357#action_12660357
] 

Harry Metske commented on JSPWIKI-452:
--------------------------------------

Also throwing a RuntimeException if an AdminBean is already registered is a bit too rigorous,
running the tests gives me 592 errors now.
This requires some more changes, all JUnit tests should properly call WikiEngine.shutdown(),
and this should then deregister all AdminBeans, this is currently not done except for the
Logger MBeans.
I'm working on it.....

> JMX implementation does not support More than one JSPWiki instance
> ------------------------------------------------------------------
>
>                 Key: JSPWIKI-452
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-452
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Core & storage
>    Affects Versions: 3.0
>         Environment: JSPWiki 3.0
>            Reporter: Harry Metske
>            Assignee: Harry Metske
>            Priority: Minor
>             Fix For: 3.0
>
>
> The current JMX implementation does not handle multiple JSPWiki instances per JVM very
well.
> This is true for both the new LoggerMBeans as for the other Admin type MBeans.
> The problem is that the ObjectName does not make the MBeans unique.
> Example names:
> JSPWiki:component=Core,name=Core bean
> JSPWiki:component=Loggers,name=com.ecyrd.jspwiki.WikiEngine
> So, depending on the order of startup, JSPWikiA or JSPWwikiB gets the MBean. 
> This can be a bit dangerous, you think you reload the Search manager for A, but B gets
it.
> But apparently we don't have that many users that use both multiple wiki's and the JMX.
> I think we need something that makes the MBean names unique. Question is what do we use
:
> 1. property jspwiki.applicationName ? (still no guarantee) 
> 2. context root of webapp (also no guarantee)
> 3. a random string appended, so this would make it like : JSPWiki-BGJSKIR:component=Core,name=Core
bean,  not very elegant
> 4. something perfect, any idea's ?
> The current AdminBeanManager also has a minor bug, saying it registers an MBean while
it didn't, I'll fix that soon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message