incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Jaquith (JIRA)" <>
Subject [jira] Closed: (JSPWIKI-452) JMX implementation does not support More than one JSPWiki instance
Date Wed, 31 Dec 2008 17:21:44 GMT


Andrew Jaquith closed JSPWIKI-452.

       Resolution: Fixed
    Fix Version/s: 3.0

Fixed in 3.0.0-svn build 41.

We now register JMX beans using the jspwiki.applicationName as part of the name. If a JMX
bean with that name is already registered, we throw a RuntimeException. 

Not the most graceful thing to do, but then, having more than 1 webapp with duplicate applicationNames
is a recipe for problems anyway. This, at least, provides a way for the admin to catch this
problem and fix it.

> JMX implementation does not support More than one JSPWiki instance
> ------------------------------------------------------------------
>                 Key: JSPWIKI-452
>                 URL:
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Core & storage
>    Affects Versions: 3.0
>         Environment: JSPWiki 3.0
>            Reporter: Harry Metske
>            Assignee: Harry Metske
>            Priority: Minor
>             Fix For: 3.0
> The current JMX implementation does not handle multiple JSPWiki instances per JVM very
> This is true for both the new LoggerMBeans as for the other Admin type MBeans.
> The problem is that the ObjectName does not make the MBeans unique.
> Example names:
> JSPWiki:component=Core,name=Core bean
> JSPWiki:component=Loggers,name=com.ecyrd.jspwiki.WikiEngine
> So, depending on the order of startup, JSPWikiA or JSPWwikiB gets the MBean. 
> This can be a bit dangerous, you think you reload the Search manager for A, but B gets
> But apparently we don't have that many users that use both multiple wiki's and the JMX.
> I think we need something that makes the MBean names unique. Question is what do we use
> 1. property jspwiki.applicationName ? (still no guarantee) 
> 2. context root of webapp (also no guarantee)
> 3. a random string appended, so this would make it like : JSPWiki-BGJSKIR:component=Core,name=Core
bean,  not very elegant
> 4. something perfect, any idea's ?
> The current AdminBeanManager also has a minor bug, saying it registers an MBean while
it didn't, I'll fix that soon.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message