incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ceki Gulcu (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JSPWIKI-376) Move from log4j to slf4j
Date Tue, 02 Dec 2008 14:28:46 GMT

    [ https://issues.apache.org/jira/browse/JSPWIKI-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652376#action_12652376
] 

Ceki Gulcu commented on JSPWIKI-376:
------------------------------------

Hello all,

Just had a cursory look at [1].

LoggerImpl has a slightly different interface than org.slf4j.Logger with different syntax
for message formatting. It lacks support for markers. Moreover, every org.slf4j.Logger instance
is wrapped by com.ecyrd.jspwik.log.LoggerImpl which will break logger selector (or repository
selector) functionality [2],not to mention serialization. 

I think that you are making things unnecessarily complicated for yourself. 

[1]  http://tinyurl.com/5unw49
[2] http://logback.qos.ch/snapshot/manual/loggingSeparation.html


> Move from log4j to slf4j
> ------------------------
>
>                 Key: JSPWIKI-376
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-376
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Core & storage
>            Reporter: Janne Jalkanen
>            Assignee: Harry Metske
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: jspwiki-log.odp
>
>
> SLF4J allows far more flexible logging than log4j, and it would allow us to get rid of
these dumb log4j compatibility problems that sometimes occur.  It also plays better with other
applications, gives the user more power to choose how to log his stuff, and is also pretty
cool otherwise. The change would be relatively trivial, and would probably be largely invisible
to the users (since we could continue shipping with necessary log4j jars).
> http://www.slf4j.org
> The license is MIT/X11, so that's fine.
> Opinions?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message