incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Janne Jalkanen <Janne.Jalka...@ecyrd.com>
Subject Re: [jira] Commented: (JSPWIKI-423) Plugins should use annotations instead of jspwiki_module.xml
Date Tue, 11 Nov 2008 06:25:25 GMT

> Discussion out side of JIRA is okay right?

Okay, but not persistent.  Which can be a problem sometimes.

> I'm frankly quite surprised at the seeming jump on the annotation
> bandwagon.  I *like* annotations and all, but I fail to see exactly  
> how
> they improve things over simply adding a few abstract methods to
> WikiPlugin such as:

Annotations can be processed externally.

Also, using abstract methods is a problem because *if* you add  
anything in the future, all your plugin classes break horribly.  So  
you need to provide an abstract baseclass, which in turn makes it  
impossible to choose your own parent class.  So you couldn't make any  
arbitrary component implement WikiPlugin.

> I mean, if a plugin class has dependencies that cause class-loading to
> fail, then annotations don't help you either right?  That reason is
> actually the *only* reason that I thought jspwiki_module.xml was maybe
> okay, you could inspect it without loading the class (which might fail
> because of dependencies).

Classloading might fail even if you *are* compatible due to missing  
libraries.  So it does not really help you out :-/

/Janne

Mime
View raw message