Return-Path: Delivered-To: apmail-incubator-jspwiki-dev-archive@locus.apache.org Received: (qmail 36470 invoked from network); 27 Sep 2008 19:04:16 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Sep 2008 19:04:16 -0000 Received: (qmail 29263 invoked by uid 500); 27 Sep 2008 19:04:14 -0000 Delivered-To: apmail-incubator-jspwiki-dev-archive@incubator.apache.org Received: (qmail 29251 invoked by uid 500); 27 Sep 2008 19:04:14 -0000 Mailing-List: contact jspwiki-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jspwiki-dev@incubator.apache.org Delivered-To: mailing list jspwiki-dev@incubator.apache.org Received: (qmail 29233 invoked by uid 99); 27 Sep 2008 19:04:14 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 Sep 2008 12:04:14 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 Sep 2008 19:03:10 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 4A62A234C1F5 for ; Sat, 27 Sep 2008 12:03:44 -0700 (PDT) Message-ID: <81733304.1222542224289.JavaMail.jira@brutus> Date: Sat, 27 Sep 2008 12:03:44 -0700 (PDT) From: "Harry Metske (JIRA)" To: jspwiki-dev@incubator.apache.org Subject: [jira] Commented: (JSPWIKI-376) Move from log4j to slf4j In-Reply-To: <1305924645.1221429464334.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JSPWIKI-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635180#action_12635180 ] Harry Metske commented on JSPWIKI-376: -------------------------------------- I did some further investigation last week on this, the details can be found at http://www.computerhok.nl/JSPWiki/Wiki.jsp?page=Slf4j. To summarize: - WebSphere version 6.1 and up no longer has a problem with JSPWiki, it installs out of the box (it appears that the common-logging-api.jar is no longer in WebSphere's lib directory, which was the root cause of the classloading problems) - I don't have a WebLogic at my disposal, so I don't know if the current version of this still has the problem. - If we switch to slf4j (which is not quite trivial), and we only ship the slf4j-simple.jar by default, we have to realize that all non-core plugins should also be changed so they also use slf4j. After all I 'm not so sure if switching to slf4j is a good idea. My assumption is that the vast majority runs on Tomcat, and only a few run on WebLogic. Switching to slf4j might break more things than it tries to repair. I have a slf4j-simple based build running om Tomcat now, it passes all tests, but still a lot of things need to be adjusted (see link above). How to continue? , opinions please.... > Move from log4j to slf4j > ------------------------ > > Key: JSPWIKI-376 > URL: https://issues.apache.org/jira/browse/JSPWIKI-376 > Project: JSPWiki > Issue Type: Improvement > Components: Core & storage > Reporter: Janne Jalkanen > Assignee: Harry Metske > Fix For: 3.0 > > > SLF4J allows far more flexible logging than log4j, and it would allow us to get rid of these dumb log4j compatibility problems that sometimes occur. It also plays better with other applications, gives the user more power to choose how to log his stuff, and is also pretty cool otherwise. The change would be relatively trivial, and would probably be largely invisible to the users (since we could continue shipping with necessary log4j jars). > http://www.slf4j.org > The license is MIT/X11, so that's fine. > Opinions? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.