incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harry Metske (JIRA)" <>
Subject [jira] Commented: (JSPWIKI-376) Move from log4j to slf4j
Date Wed, 17 Sep 2008 19:17:44 GMT


Harry Metske commented on JSPWIKI-376:

So, reading through the sl4j documentation I have the following notes/questions :
- We run the sl4j migrator and thereby do a mass change to our source code, and probably pick
up some low hanging fruit by using formatted log messages ?
- Keep using log4j.jar during compile, and also include slf4j-api.jar ?
- Leave out log4j.jar in JSPWiki.war, and rely on each container's logging implementation
?  I guess this is necessary to eliminate the classloading issues ??
- Should we ship all slf4j binding files for the logging implementations (log4j, nop, simple,
jdk14) in the war outside the classpath and let the person who deploys JSPWiki pick the right
one and put it in the WEB-INF/lib ?  (an extra step for the deployer)
- How to configure the logging ?  Currently WikiEngine does a log4j PropertyConfigurator.doConfigure()
, this is not supported by slf4j. For log4j it could simple be solved by adding a log4j.xml
config file somewhere in the classpath. (Still no dynamic configuration possible :-( )

> Move from log4j to slf4j
> ------------------------
>                 Key: JSPWIKI-376
>                 URL:
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Core & storage
>            Reporter: Janne Jalkanen
>             Fix For: 3.0
> SLF4J allows far more flexible logging than log4j, and it would allow us to get rid of
these dumb log4j compatibility problems that sometimes occur.  It also plays better with other
applications, gives the user more power to choose how to log his stuff, and is also pretty
cool otherwise. The change would be relatively trivial, and would probably be largely invisible
to the users (since we could continue shipping with necessary log4j jars).
> The license is MIT/X11, so that's fine.
> Opinions?

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message