incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Janne Jalkanen (JIRA)" <>
Subject [jira] Commented: (JSPWIKI-351) Incorrect bundles specified in JSPs
Date Wed, 20 Aug 2008 17:06:46 GMT


Janne Jalkanen commented on JSPWIKI-351:

CoreResources is meant for properties which do not vary from one template to another, and
also for strings which are used inside jspwiki main classes (just look them up; auth classes
and the lot use coreresources). is meant for strings used by the default template.  Another template would
use a separate set of strings.  This separation makes it possible for template developers
to deploy a separate template with a separate localization without mucking around in the jspwiki

As the top-level JSP files do not vary from template to template, their resources belong to
CoreResources.  In the future, when their functionality becomes a part of the Stripes ActionBeans,
it would be very odd to have the resources located in  that would mean
that a template developer would need to "guess" which of the resource keys are not used by
the template, and which are required by the core code.

-1 from me.

> Incorrect bundles specified in JSPs
> -----------------------------------
>                 Key: JSPWIKI-351
>                 URL:
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Default template
>    Affects Versions: 2.8
>         Environment: All
>            Reporter: Andrew Jaquith
>             Fix For: 2.8
>   Original Estimate: 2h
>  Remaining Estimate: 2h
> i18n strings are improperly stored in CoreResources_*.properties, when they should have
been specified in templates/default_*.properties. The comments at the top of CoreResources
specifies that messages are for "JSPWiki internal code, the so-called core code." But these
JSPs all look up and use message strings from CoreResources:
> * Comment.jsp
> * Install.jsp
> * LostPassword.jsp
> * NewGroup.jsp
> * Rename.jsp
> Example: 
>         // Weepy tears and hankies all 'round.
>         if( wikiSession.isAuthenticated() )
>         {
>             response.sendError( HttpServletResponse.SC_FORBIDDEN, rb.getString("login.error.noaccess")
>             return;
>         }
> This is clearly a template/JSP-level error message, NOT an internal error. And similar
kinds of code are sprinked all over the other JSPs.
> I recommend we consolidate and The easiest
way would simply be to concatenate the files. Then, in WikiContext.getBundle(), any requests
for "CoreResources" could be simply diverted to

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message