incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Janne Jalkanen <Janne.Jalka...@ecyrd.com>
Subject Re: Image thumbnail proposal
Date Mon, 04 Aug 2008 08:36:38 GMT

Agree.  Postpone to 2.8.1.  In the mean time, keep it in your own  
copy.  Also possible to start your own branch (like we've done with  
JSPWIKI_JANNE_BRANCH and JSPWIKI_ARJ_BRANCH.)

Git would be so much better in this regard.

/Janne

On Aug 4, 2008, at 06:30 , Andrew Jaquith wrote:

> Sounds great (seriously!)... but I think it might have to wait  
> until 2.8.1. We need to fix bugs at this point rather than add  
> features. In fact, I think we ought to promote the current Alpha to  
> Beta.
>
> Andrew
>
> On Aug 3, 2008, at 8:55 PM, Murray Altheim wrote:
>
>> Hi,
>>
>> I've got a new proposal to add a thumbnail feature to the Image  
>> plugin.
>> This entails a few changes to the Image plugin and an additional  
>> utility
>> class to generate the thumbnails.
>>
>> Basically, the syntax is augmented such that a value of  
>> "thumbnail" in
>> the 'link' parameter will generate a thumbnail, with the thumbnail a
>> link to the original image. Optionally the 'width' parameter can  
>> be used
>> to set the width of the generated thumbnail (the height is ignored  
>> as it
>> is proportional to width). This works for PNG, JPEG and GIF images --
>> other image types throw an PluginException. E.g.,
>>
>>  [{Image src='attach/ForumPlugin/forum1.png' link='thumbnail'}]
>>
>> This works with relative paths on the server (except those beginning
>> with "..", which is prohibited), as well as external (http:)  
>> references.
>> The generated thumbnails are cached in ./work/thumbnails/.
>>
>> I've tested this and haven't noted any problems with it.
>>
>> If this is approved I'd like to know which branch to submit it to in
>> SVN (e.g., trunk?).
>>
>> Murray
>>
>> ..................................................................... 
>> ......
>> Murray Altheim <murray07 at altheim.com>                            
>> ===  = =
>> http://www.altheim.com/murray/                                      
>> = =  ===
>> SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk                
>> = =  = =
>>
>>      Boundless wind and moon - the eye within eyes,
>>      Inexhaustible heaven and earth - the light beyond light,
>>      The willow dark, the flower bright - ten thousand houses,
>>      Knock at any door - there's one who will respond.
>>                                      -- The Blue Cliff Record


Mime
View raw message