incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Jaquith (JIRA)" <j...@apache.org>
Subject [jira] Created: (JSPWIKI-351) Incorrect bundles specified in JSPs
Date Wed, 20 Aug 2008 14:50:44 GMT
Incorrect bundles specified in JSPs
-----------------------------------

                 Key: JSPWIKI-351
                 URL: https://issues.apache.org/jira/browse/JSPWIKI-351
             Project: JSPWiki
          Issue Type: Bug
          Components: Default template
    Affects Versions: 2.8
         Environment: All
            Reporter: Andrew Jaquith
             Fix For: 2.8


i18n strings are improperly stored in CoreResources_*.properties, when they should have been
specified in templates/default_*.properties. The comments at the top of CoreResources specifies
that messages are for "JSPWiki internal code, the so-called core code." But these JSPs all
look up and use message strings from CoreResources:
* Comment.jsp
* Install.jsp
* LostPassword.jsp
* NewGroup.jsp
* Rename.jsp

Example: 

        // Weepy tears and hankies all 'round.
        if( wikiSession.isAuthenticated() )
        {
            response.sendError( HttpServletResponse.SC_FORBIDDEN, rb.getString("login.error.noaccess")
);
            return;
        }

This is clearly a template/JSP-level error message, NOT an internal error. And similar kinds
of code are sprinked all over the other JSPs.

I recommend we consolidate default.properties and CoreResources.properties. The easiest way
would simply be to concatenate the files. Then, in WikiContext.getBundle(), any requests for
"CoreResources" could be simply diverted to default.properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message