Return-Path: Delivered-To: apmail-incubator-jspwiki-dev-archive@locus.apache.org Received: (qmail 62788 invoked from network); 14 Jun 2008 19:02:28 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 14 Jun 2008 19:02:28 -0000 Received: (qmail 4986 invoked by uid 500); 14 Jun 2008 19:02:30 -0000 Delivered-To: apmail-incubator-jspwiki-dev-archive@incubator.apache.org Received: (qmail 4973 invoked by uid 500); 14 Jun 2008 19:02:30 -0000 Mailing-List: contact jspwiki-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jspwiki-dev@incubator.apache.org Delivered-To: mailing list jspwiki-dev@incubator.apache.org Received: (qmail 4962 invoked by uid 99); 14 Jun 2008 19:02:30 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Jun 2008 12:02:30 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of Janne.Jalkanen@ecyrd.com designates 193.64.5.122 as permitted sender) Received: from [193.64.5.122] (HELO mail.ecyrd.com) (193.64.5.122) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Jun 2008 19:01:40 +0000 Received: from [192.168.0.10] (cs181005170.pp.htv.fi [82.181.5.170]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.ecyrd.com (Postfix) with ESMTP id 650AA4810D for ; Sat, 14 Jun 2008 22:01:12 +0300 (EEST) Mime-Version: 1.0 (Apple Message framework v753.1) In-Reply-To: References: <1238358182.1213459785222.JavaMail.jira@brutus> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <37B6829E-C51E-4776-A835-8083619E32F7@ecyrd.com> Content-Transfer-Encoding: 7bit From: Janne Jalkanen Subject: Re: [jira] Commented: (JSPWIKI-57) UserManager & JSONUserModule missing Serializable Date: Sat, 14 Jun 2008 22:01:13 +0300 To: jspwiki-dev@incubator.apache.org X-Mailer: Apple Mail (2.753.1) X-Virus-Checked: Checked by ClamAV on apache.org The problem is that the jsonrpc lib puts the JSON objects in the session. And since JSONUserModule is not a static class, it contains a reference to UserManager. Which in turn makes the container serialize the whole shebang... One trick would be to make the reference volatile. But that would mean that whenever the container deserializes the whole thing, the JSONUserModule is no longer valid, and will break horribly. /Janne On Jun 14, 2008, at 21:15 , Andrew Jaquith wrote: > Forgive my ignorance, but why does UserManager need to be > serializable?It is a manager class, not an object that needs to be > persisted. Is there an object reference or something we can remove? > > On Jun 14, 2008, at 12:09 PM, "Harry Metske (JIRA)" > wrote: > >> >> [ https://issues.apache.org/jira/browse/JSPWIKI-57? >> page=com.atlassian.jira.plugin.system.issuetabpanels:comment- >> tabpanel&focusedCommentId=12605084#action_12605084 ] >> >> Harry Metske commented on JSPWIKI-57: >> ------------------------------------- >> >> The last time I have seen this exception in my logs is 2 May 2008, >> and I regularly upgrade my wiki's to the latest version. Has it >> been fixed in between? >> >>> UserManager & JSONUserModule missing Serializable >>> -------------------------------------------------- >>> >>> Key: JSPWIKI-57 >>> URL: https://issues.apache.org/jira/browse/JSPWIKI-57 >>> Project: JSPWiki >>> Issue Type: Bug >>> Components: Core & storage >>> Affects Versions: 2.6.0 >>> Environment: All >>> Reporter: Dave Wolf >>> Priority: Trivial >>> Fix For: 2.8 >>> >>> Attachments: 20071125-patch.txt >>> >>> >>> Errors being thrown in Catalina logs complaining that the >>> UserManager and its inner class JSONUserModule not being >>> Serializable. >> >> -- >> This message is automatically generated by JIRA. >> - >> You can reply to this email to add a comment to the issue online. >>