incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Jaquith <andrew.jaqu...@mac.com>
Subject Re: [jira] Commented: (JSPWIKI-57) UserManager & JSONUserModule missing Serializable
Date Sat, 14 Jun 2008 20:37:47 GMT
There is nothing in JSONUserModuke that requires it to have privileged  
access to any of UserManager's innards. So it could easily be made  
into a stand-alone class.

As for the direct reference, is there some way we could obtain the  
UserManager via lookup rather than maintaining a hard reference? That  
would solve the problem...

On Jun 14, 2008, at 3:01 PM, Janne Jalkanen <Janne.Jalkanen@ecyrd.com>  
wrote:

>
> The problem is that the jsonrpc lib puts the JSON objects in the  
> session.  And since JSONUserModule is not a static class, it  
> contains a reference to UserManager.  Which in turn makes the  
> container serialize the whole shebang...
>
> One trick would be to make the reference volatile.  But that would  
> mean that whenever the container deserializes the whole thing, the  
> JSONUserModule is no longer valid, and will break horribly.
>
> /Janne
>
> On Jun 14, 2008, at 21:15 , Andrew Jaquith wrote:
>
>> Forgive my ignorance, but why does UserManager need to be  
>> serializable?It is a manager class, not an object that needs to be  
>> persisted. Is there an object reference or something we can remove?
>>
>> On Jun 14, 2008, at 12:09 PM, "Harry Metske (JIRA)"  
>> <jira@apache.org> wrote:
>>
>>>
>>>   [ https://issues.apache.org/jira/browse/JSPWIKI-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605084#action_12605084

>>>  ]
>>>
>>> Harry Metske commented on JSPWIKI-57:
>>> -------------------------------------
>>>
>>> The last time I have seen this exception in my logs is 2 May 2008,  
>>> and I regularly upgrade my wiki's to the latest version. Has it  
>>> been fixed in between?
>>>
>>>> UserManager & JSONUserModule missing Serializable
>>>> --------------------------------------------------
>>>>
>>>>               Key: JSPWIKI-57
>>>>               URL: https://issues.apache.org/jira/browse/JSPWIKI-57
>>>>           Project: JSPWiki
>>>>        Issue Type: Bug
>>>>        Components: Core & storage
>>>>  Affects Versions: 2.6.0
>>>>       Environment: All
>>>>          Reporter: Dave Wolf
>>>>          Priority: Trivial
>>>>           Fix For: 2.8
>>>>
>>>>       Attachments: 20071125-patch.txt
>>>>
>>>>
>>>> Errors being thrown in Catalina logs complaining that the  
>>>> UserManager and its inner class JSONUserModule not being  
>>>> Serializable.
>>>
>>> -- 
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>

Mime
View raw message