incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harry Metske (JIRA)" <>
Subject [jira] Commented: (JSPWIKI-283) modified WIKIWORD_REGEX in JSPWikiMarkupParser causes a lot JUNIT tests to fail with an NPE
Date Sun, 08 Jun 2008 12:11:45 GMT


Harry Metske commented on JSPWIKI-283:

O BTW, this is the stacktrace:

	at com.ecyrd.jspwiki.parser.JSPWikiMarkupParser.makeLink(
	at com.ecyrd.jspwiki.parser.JSPWikiMarkupParser.makeCamelCaseLink(
	at com.ecyrd.jspwiki.parser.JSPWikiMarkupParser.flushPlainText(
	at com.ecyrd.jspwiki.parser.JSPWikiMarkupParser.makeLink(
	at com.ecyrd.jspwiki.parser.JSPWikiMarkupParser.handleHyperlinks(
	at com.ecyrd.jspwiki.parser.JSPWikiMarkupParser.handleOpenbracket(
	at com.ecyrd.jspwiki.parser.JSPWikiMarkupParser.parseToken(
	at com.ecyrd.jspwiki.parser.JSPWikiMarkupParser.fillBuffer(
	at com.ecyrd.jspwiki.parser.JSPWikiMarkupParser.parse(
	at com.ecyrd.jspwiki.render.RenderingManager.getRenderedDocument(
	at com.ecyrd.jspwiki.render.RenderingManager.getHTML(
	at com.ecyrd.jspwiki.WikiEngine.textToHTML(
	at com.ecyrd.jspwiki.PageManager$SaveWikiPageTask.execute(
	at com.ecyrd.jspwiki.workflow.Workflow.processCurrentStep(
	at com.ecyrd.jspwiki.workflow.Workflow.start(
	at com.ecyrd.jspwiki.workflow.WorkflowManager.start(
	at com.ecyrd.jspwiki.WikiEngine.saveText(
	at com.ecyrd.jspwiki.TestEngine.saveText(
	at com.ecyrd.jspwiki.ReferenceManagerTest.setUp(
	at junit.framework.TestCase.runBare(
	at junit.framework.TestResult$1.protect(
	at junit.framework.TestResult.runProtected(
	at junit.framework.TestSuite.runTest(
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(

> modified WIKIWORD_REGEX in JSPWikiMarkupParser causes a lot JUNIT tests to fail with
an NPE
> -------------------------------------------------------------------------------------------
>                 Key: JSPWIKI-283
>                 URL:
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Core & storage
>    Affects Versions: 2.7.x
>         Environment: Ubuntu Linux 7.04 
> JSPWiki  2.7.0-svn-34
>            Reporter: Harry Metske
>            Priority: Minor
> While running JUNIT tests I notice several 787 errors, the overall success rate drops
from 98 % to 26% .
> Digging a little further brings me to a modified JSPWikiMarkupParser. The revision comment
says that only String(Buffer) has been replaced by StringBuilder.
> However, I notice another change in the static final String WIKIWORD_REGEX
> new:   "(^|<|(http://|https://|mailto:)([A-Za-z0-9_/\\.\\+\\?\\#\\-\\@=&;~%]+))";
> old:  "(^|[[:^alnum:]]+)([[:upper:]]+[[:lower:]]+[[:upper:]]+[[:alnum:]]*|(http://|https://|mailto:)([A-Za-z0-9_/\\.\\+\\?\\#\\-\\@=&;~%]+))";
> Reverting this change gives me the old better JUNIT test results again.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message