incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harry Metske (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JSPWIKI-283) modified WIKIWORD_REGEX in JSPWikiMarkupParser causes a lot JUNIT tests to fail with an NPE
Date Sun, 08 Jun 2008 12:11:45 GMT

    [ https://issues.apache.org/jira/browse/JSPWIKI-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603372#action_12603372
] 

Harry Metske commented on JSPWIKI-283:
--------------------------------------

O BTW, this is the stacktrace:

java.lang.NullPointerException
	at com.ecyrd.jspwiki.parser.JSPWikiMarkupParser.makeLink(JSPWikiMarkupParser.java:517)
	at com.ecyrd.jspwiki.parser.JSPWikiMarkupParser.makeCamelCaseLink(JSPWikiMarkupParser.java:1190)
	at com.ecyrd.jspwiki.parser.JSPWikiMarkupParser.flushPlainText(JSPWikiMarkupParser.java:863)
	at com.ecyrd.jspwiki.parser.JSPWikiMarkupParser.makeLink(JSPWikiMarkupParser.java:639)
	at com.ecyrd.jspwiki.parser.JSPWikiMarkupParser.handleHyperlinks(JSPWikiMarkupParser.java:1600)
	at com.ecyrd.jspwiki.parser.JSPWikiMarkupParser.handleOpenbracket(JSPWikiMarkupParser.java:2224)
	at com.ecyrd.jspwiki.parser.JSPWikiMarkupParser.parseToken(JSPWikiMarkupParser.java:2799)
	at com.ecyrd.jspwiki.parser.JSPWikiMarkupParser.fillBuffer(JSPWikiMarkupParser.java:2599)
	at com.ecyrd.jspwiki.parser.JSPWikiMarkupParser.parse(JSPWikiMarkupParser.java:2858)
	at com.ecyrd.jspwiki.render.RenderingManager.getRenderedDocument(RenderingManager.java:234)
	at com.ecyrd.jspwiki.render.RenderingManager.getHTML(RenderingManager.java:315)
	at com.ecyrd.jspwiki.WikiEngine.textToHTML(WikiEngine.java:1484)
	at com.ecyrd.jspwiki.PageManager$SaveWikiPageTask.execute(PageManager.java:752)
	at com.ecyrd.jspwiki.workflow.Workflow.processCurrentStep(Workflow.java:763)
	at com.ecyrd.jspwiki.workflow.Workflow.start(Workflow.java:678)
	at com.ecyrd.jspwiki.workflow.WorkflowManager.start(WorkflowManager.java:82)
	at com.ecyrd.jspwiki.WikiEngine.saveText(WikiEngine.java:1729)
	at com.ecyrd.jspwiki.TestEngine.saveText(TestEngine.java:264)
	at com.ecyrd.jspwiki.ReferenceManagerTest.setUp(ReferenceManagerTest.java:50)
	at junit.framework.TestCase.runBare(TestCase.java:125)
	at junit.framework.TestResult$1.protect(TestResult.java:106)
	at junit.framework.TestResult.runProtected(TestResult.java:124)
	at junit.framework.TestResult.run(TestResult.java:109)
	at junit.framework.TestCase.run(TestCase.java:118)
	at junit.framework.TestSuite.runTest(TestSuite.java:208)
	at junit.framework.TestSuite.run(TestSuite.java:203)
	at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196)

> modified WIKIWORD_REGEX in JSPWikiMarkupParser causes a lot JUNIT tests to fail with
an NPE
> -------------------------------------------------------------------------------------------
>
>                 Key: JSPWIKI-283
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-283
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Core & storage
>    Affects Versions: 2.7.x
>         Environment: Ubuntu Linux 7.04 
> JSPWiki  2.7.0-svn-34
>            Reporter: Harry Metske
>            Priority: Minor
>
> While running JUNIT tests I notice several 787 errors, the overall success rate drops
from 98 % to 26% .
> Digging a little further brings me to a modified JSPWikiMarkupParser. The revision comment
says that only String(Buffer) has been replaced by StringBuilder.
> However, I notice another change in the static final String WIKIWORD_REGEX
> new:   "(^|<|(http://|https://|mailto:)([A-Za-z0-9_/\\.\\+\\?\\#\\-\\@=&;~%]+))";
> old:  "(^|[[:^alnum:]]+)([[:upper:]]+[[:lower:]]+[[:upper:]]+[[:alnum:]]*|(http://|https://|mailto:)([A-Za-z0-9_/\\.\\+\\?\\#\\-\\@=&;~%]+))";
> Reverting this change gives me the old better JUNIT test results again.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message