incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Janne Jalkanen <Janne.Jalka...@ecyrd.com>
Subject Re: [jira] Commented: (JSPWIKI-208) Hide RSS images if deactivated
Date Wed, 14 May 2008 19:29:22 GMT

On May 14, 2008, at 22:15 , Dirk Frederickx wrote:

> Janne,
>
>
> This allows skins to change the image.
>
> This has been a generic approach throughout the new template. (logo's,
> other images,  only the attachment icons still need to be handled)
> Ensure presentation stuff is moved to css, so it can be changed
> according the skins.
>
> In the below code snippit, the &nbsp; should actually be changed by a
> line-of-text, eg "RSS-feed", so things are still accessible when icons
> are not loaded.

But it causes a massive cases of duplicate code all around!  We've  
got the perfectly good RSSImageLink tag, so we should use it  
instead.  Note that now we are using both, so a skin cannot really  
change the icon at all.

Also, I am not sure whether that increases accessibility (I know,  
it's already pretty bad), but having a &nbsp; as link text is  
probably not what we really want.

I think it should be much better to move all this code into  
RSSImageLinkTag.

/Janne

Mime
View raw message