Return-Path: Delivered-To: apmail-incubator-jspwiki-dev-archive@locus.apache.org Received: (qmail 60081 invoked from network); 1 Apr 2008 05:50:11 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 1 Apr 2008 05:50:11 -0000 Received: (qmail 96171 invoked by uid 500); 1 Apr 2008 05:50:11 -0000 Delivered-To: apmail-incubator-jspwiki-dev-archive@incubator.apache.org Received: (qmail 96161 invoked by uid 500); 1 Apr 2008 05:50:11 -0000 Mailing-List: contact jspwiki-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jspwiki-dev@incubator.apache.org Delivered-To: mailing list jspwiki-dev@incubator.apache.org Received: (qmail 96122 invoked by uid 99); 1 Apr 2008 05:50:11 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Mar 2008 22:50:11 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of Janne.Jalkanen@ecyrd.com designates 193.64.5.122 as permitted sender) Received: from [193.64.5.122] (HELO mail.ecyrd.com) (193.64.5.122) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Apr 2008 05:49:20 +0000 Received: from [192.168.0.10] (cs181005170.pp.htv.fi [82.181.5.170]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.ecyrd.com (Postfix) with ESMTP id DA4D248136 for ; Tue, 1 Apr 2008 08:49:05 +0300 (EEST) Mime-Version: 1.0 (Apple Message framework v753) In-Reply-To: References: Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Janne Jalkanen Subject: Re: And now for something completely different Date: Tue, 1 Apr 2008 08:50:35 +0300 To: jspwiki-dev@incubator.apache.org X-Mailer: Apple Mail (2.753) X-Virus-Checked: Checked by ClamAV on apache.org No objection; I think it would be fine to use for testing (as long as you put the library in tests/lib). Or you could just extract the mock objects themselves and not bring in the rest of the baggage yet. /Janne On Apr 1, 2008, at 05:22 , Andrew Jaquith wrote: > ...in other words, not related to the @author thread. > > I'm currently checking in a bunch of changes related to auth > refactoring. Some of the files I'm checking in include some really > minimal mock servlet objects: TestFilterChain, TestFilterConfig, > TestHttpServletResponse, and TestServletContext. > > These are pretty hack-y. They do the absolute bare minimum required > of them, and no more. > > However, Stripes has some pretty terrific mock objects that are > part of the standard jar. I'd kinda like to use them instead. It > wouldn't obligate us to use the whole Stripes stack, of course. We > would incorporate Stripes functionality later, in the 3.0 builds. > > Not passionate about this, but I hate writing classes that I know > we'll eliminate later. > > What do you all think? > > Andrew