incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Janne Jalkanen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JSPWIKI-50) RecentChanges plugin is slow
Date Mon, 14 Apr 2008 20:47:05 GMT

    [ https://issues.apache.org/jira/browse/JSPWIKI-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588788#action_12588788
] 

Janne Jalkanen commented on JSPWIKI-50:
---------------------------------------

OK, this is now just plain strange: why do we have three caches?  One to store a Collection
of attachments with a key by the page name; one which has Attachments with a key directly
by the attachment name, and also a HashMap to store all, just to be on the safe side.

And, for that matter, why do we have two caches in CachingProvider?

Ugh.  I think we should rethink this.  These structures make no sense at all (and yes, I wrote
the CachingProvider...)

> RecentChanges plugin is slow
> ----------------------------
>
>                 Key: JSPWIKI-50
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-50
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Plugins
>            Reporter: Janne Jalkanen
>            Assignee: Harry Metske
>            Priority: Minor
>             Fix For: 2.8
>
>         Attachments: CachedAttachmentCollector.java, CachingAttachmentProvider.patch,
PageTimeComparator.patch, Screenshot-20252 msec -- -tmp-jip-profile.xml.png
>
>
> RecentChanges plugin gets awfully slow once the repository gets big enough.  It might
be a good idea to cache something or do some other performance optimizations.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message