incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Florian Holeczek (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JSPWIKI-30) Rename may cause dataloss
Date Thu, 20 Mar 2008 08:43:29 GMT

    [ https://issues.apache.org/jira/browse/JSPWIKI-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580697#action_12580697
] 

Florian Holeczek commented on JSPWIKI-30:
-----------------------------------------

Ha! I was able to reproduce it on my own wiki (y)

1. Insert the "culprit text" from the realerrorpage.txt into some wiki page (its name doesn't
matter)
2. Create a page named ThisPageDoesNotExist, content doesn't matter.
3. that's the point: the error only happens when jspwiki.translatorReader.camelCaseLinks =
true
4. There's a question on the page which contains ThisPageDoesNotExist (not as a link, but
it's converted to one because of the CamelCase setting, of course). When renaming ThisPageDoesNotExist
to ThisPageDoesExist (checked update references), the error rises.

Haven't got the time to debug this now, but it seems to me as if fixing this won't be a problem
any more now.

> Rename may cause dataloss
> -------------------------
>
>                 Key: JSPWIKI-30
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-30
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Core & storage
>    Affects Versions: 2.5.139-beta
>            Reporter: Janne Jalkanen
>            Priority: Critical
>             Fix For: 2.8
>
>         Attachments: realerrorpage.txt, Rename.jsp.html
>
>
> If rename fails due to an exception in PageRenamer, the end result may be wiping out
of some of the pages that refer to the linking page.  The preconditions seem to include a
complicated link sentence.  I managed to get this to happen on jspwiki.org by renaming page
"MyCodingStandard" to "JSPWikiCodingStandard", which resulted in some of the renaming to fail.
 I think some of the links were of the form "my coding standard".
> Suggested correction: let's get rid of the link "guesser", and just modify the actual
link reference - and if it's missing, we'll add one.
> Note that this is not real dataloss; you can still get the old page from the page history.
 It just causes a new, empty page to be put into the repository.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message