Return-Path: 
 <jspwiki-dev-return-692-apmail-incubator-jspwiki-dev-archive=incubator.apache.org@incubator.apache.org>
Delivered-To: apmail-incubator-jspwiki-dev-archive@locus.apache.org
Received: (qmail 73175 invoked from network); 7 Jan 2008 18:54:42 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 7 Jan 2008 18:54:42 -0000
Received: (qmail 40769 invoked by uid 500); 7 Jan 2008 18:54:32 -0000
Delivered-To: apmail-incubator-jspwiki-dev-archive@incubator.apache.org
Received: (qmail 40715 invoked by uid 500); 7 Jan 2008 18:54:32 -0000
Mailing-List: contact jspwiki-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:jspwiki-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:jspwiki-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:jspwiki-dev@incubator.apache.org>
List-Id: <jspwiki-dev.incubator.apache.org>
Reply-To: jspwiki-dev@incubator.apache.org
Delivered-To: mailing list jspwiki-dev@incubator.apache.org
Received: (qmail 40706 invoked by uid 99); 7 Jan 2008 18:54:32 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Jan 2008 10:54:32 -0800
X-ASF-Spam-Status: No, hits=-0.0 required=10.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of Janne.Jalkanen@ecyrd.com
 designates 193.64.5.122 as permitted sender)
Received: from [193.64.5.122] (HELO mail.ecyrd.com) (193.64.5.122)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Jan 2008 18:54:07 +0000
Received: from [192.168.0.10] (cs181005170.pp.htv.fi [82.181.5.170])
	(using TLSv1 with cipher AES128-SHA (128/128 bits))
	(No client certificate requested)
	by mail.ecyrd.com (Postfix) with ESMTP id E84EA48409
	for <jspwiki-dev@incubator.apache.org>; Mon,  7 Jan 2008 20:53:55 +0200 (EET)
In-Reply-To: <1189589152.20080107192006@holeczek.de>
References: <155895313.20080106171441@holeczek.de>
 <1189589152.20080107192006@holeczek.de>
Mime-Version: 1.0 (Apple Message framework v753)
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <F853D4E4-0D29-4856-963C-A459C5C49ADB@ecyrd.com>
Content-Transfer-Encoding: 7bit
From: Janne Jalkanen <Janne.Jalkanen@ecyrd.com>
Subject: Re: jspwiki_module.xml
Date: Mon, 7 Jan 2008 20:53:42 +0200
To: jspwiki-dev@incubator.apache.org
X-Mailer: Apple Mail (2.753)
X-Virus-Checked: Checked by ClamAV on apache.org

Hi!

(I would appreciate it if you would keep the responses only to the  
list; I don't much care if I receive the same email  multiple times.)

It would appear that there is a bug; looks like FilterManager does  
not properly extend from ModuleManager, and therefore does not check  
for filter compatibility.  Could you file this as an issue and mark  
it for 2.6.1, please?

/Janne

On Jan 7, 2008, at 20:20 , Florian Holeczek wrote:

> Hi folks,
>
> I'm asking again, because I got no answers and it's the only thing
> that keeps me from uploading the EmoticonsFilter for 2.6.
>
> Especially Janne (you told me about the jspwiki_module.xml in another
> mail): where's the problem or mistake?
> Maybe the jspwiki_module.xml doesn't apply to filters?
>
> Regards,
>  Florian
>
> ======================== original text ===================
> Hi all,
>
> I've just tried to use jspwiki_module.xml with the EmoticonsFilter.
> Here's what I've done:
>
> I've placed a jspwiki_module.xml into the /ini directory in the jar
> file with the following content:
> ---
> <?xml version="1.0" encoding="UTF-8"?>
> <modules>
>         <plugin  
> class="org.stringfellow.jspwiki.emoticons.EmoticonsFilter">
>                 <minVersion>2.7</minVersion>
>         </plugin>
> </modules>
> ---
>
> However, JSPWiki 2.6.0 still applies the Filter. Anybody knows where's
> the mistake?
>
> Regards,
>  Florian
>
> =================== End of original text =============