Mailing-List: contact jspwiki-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jspwiki-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of Janne.Jalkanen@ecyrd.com
 designates 193.64.5.122 as permitted sender)
Mime-Version: 1.0 (Apple Message framework v753)
In-Reply-To: <15F17722-ECDB-49DD-9351-E6F21AEC2C02@mac.com>
References: <3a6c97f00801281106j5f8c58bfw5f3f5bb45504da64@mail.gmail.com>
 <8B0E4365-B26A-42C1-8E2A-87DE8C5F0589@mac.com>
 <EE9BFADF-769A-4A41-AB8A-7CA211F8522C@ecyrd.com>
 <15F17722-ECDB-49DD-9351-E6F21AEC2C02@mac.com>
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <7602C4C4-B724-4B51-9FAD-C0A49B4A89F3@ecyrd.com>
Content-Transfer-Encoding: 7bit
From: Janne Jalkanen <Janne.Jalkanen@ecyrd.com>
Subject: Re: status of Unit Tests ?
Date: Tue, 29 Jan 2008 05:42:48 +0200
To: jspwiki-dev@incubator.apache.org


Yes, I do pass these arguments (and -Xmx1024m, just to be sure).  No,  
they still won't run.

/Janne

On Jan 28, 2008, at 23:37 , Andrew Jaquith wrote:

> So, it looks like we've all got some variations in our respective  
> setups that are different tests to fail! How annoying.
>
> Janne, as for Eclipse: in your Run... setup for the JSPWiki JUnit  
> tests, make sure you pass these VM arguments:
>
> -Djava.security.auth.login.config==${project_loc}/etc/jspwiki.jaas - 
> Djspwiki.tests.auth=true
>
> Then, all of the testStaticPermissions tests should run. As for  
> XMLUserDatabaseTest, I've found sometimes that the userdatabase.xml  
> database isn't always "pristine" at the start of the tests, and it  
> needs to be refreshed with a clean copy. The Ant tests-init target  
> does this automatically, but Eclipse doesn't....
>
> Andrew
>
>
> On Jan 28, 2008, at 4:23 PM, Janne Jalkanen wrote:
>
>> Hi!
>>
>> I only get 2 failures:  
>> AuthorizationManagerTest.testStaticPermissions (it's my setup  
>> probably; it works if I run ant tests); and  
>> XMLUserDatabaseTest.getWikiNames(), which I can't get to run.
>>
>> All others work fine, and I run them regularly, so yes, they are  
>> absolutely and actively maintained.  *BUT* I run them from  
>> Eclipse, never with ant guitests or ant tests, except to run auth  
>> tests (where the ant setup seems to be more stable than Eclipse -  
>> there is probably some interaction with some SecurityManager or  
>> something).
>>
>> /Janne
>>
>> On Jan 28, 2008, at 21:28 , Andrew Jaquith wrote:
>>
>>> As of last night, my test runs are much better: 3 failures and 2  
>>> errors:
>>>
>>> PageRenamerTest (2 errors):
>>>    testBug85_case3: out of memory
>>>    testBug85_case4: out of memory
>>>
>>> ReferringPagesPluginTest (1 failure):
>>>    testMaxReferences  expected:<5> but was:<7>
>>>
>>> MassiveRepositoryTest (1 failure):
>>>    testMassiveRepository1 - Right number of pages expected:<1000>  
>>> but was:<1001>
>>>
>>> MailUtilTest (1 failure):
>>>    testSendMail: Could not send mail: Could not connect to SMTP  
>>> host: 127.0.0.1, port: 25
>>>
>>> On MailUtilTest, this is failing because I haven't set up my  
>>> localhost mail relay. That's because I am lazy. So really, it's  
>>> probably like 2 failures and 2 errors.
>>>
>>> In the test results you posted, 18 of the 25 errors seem to be  
>>> related to this:
>>>
>>> java.lang.NullPointerException
>>> at java.util.Calendar.setTime(Calendar.java:1032)
>>> at java.text.SimpleDateFormat.format(SimpleDateFormat.java:785)
>>> at java.text.SimpleDateFormat.format(SimpleDateFormat.java:778)
>>> at java.text.DateFormat.format(DateFormat.java:314)
>>> at com.ecyrd.jspwiki.auth.authorize.XMLGroupDatabase.saveDOM 
>>> (XMLGroupDatabase.java:429)
>>>
>>> As far as I know, this code has been pretty stable for a while. I  
>>> don't know why it would be giving you trouble, but not me. Could  
>>> you file a bug report on this?
>>>
>>> I see other errors related to the RCS file system -- I'm not  
>>> having those, either.
>>>
>>>
>>>
>>> Andrew
>>>
>>> On Jan 28, 2008, at 2:06 PM, Harry Metske wrote:
>>>
>>>> Hi all,
>>>>
>>>> the last few weeks I have been running the ant tests task a  
>>>> couple of times,
>>>> and I noticed that there are quite a few failures (5) and errors  
>>>> (29).
>>>> (For details see : http://www.computerhok.nl/tmp/junit- 
>>>> noframes.html )
>>>>
>>>> So I have a few questions :
>>>> 1. Are the unit tests actively maintained ?
>>>> 2. Are there instructions available specifically for running  
>>>> JSPWiki Unit
>>>> tests ? (Setting up the environment, now I just cd to ./ 
>>>> workspace/JSPWiki
>>>> and run "ant tests") ?
>>>> 3. Should we ignore (some of) these errors (I personally think  
>>>> we shouldn't)
>>>> ?
>>>> 4. Is there a specific reason for running JSPWiki with log4j  
>>>> DEBUG level
>>>> (file ./etc/jspwiki.properties), this creates a 10 MB logfile  
>>>> for every test
>>>> run.
>>>> 5. Any other comments....
>>>>
>>>> Just as an excercies for myself I fixed the
>>>> ReferrringPagesPlugin.testMaxReferences(), should I open an  
>>>> issue for these
>>>> (with patches) ?
>>>>
>>>> regards,
>>>> Harry
>>>>
>>>> -- 
>>>> met vriendelijke groet,
>>>> Harry Metske
>>>> Telnr. +31-548-512395
>>>> Mobile +31-6-51898081
>>