Return-Path: Delivered-To: apmail-incubator-jspwiki-dev-archive@locus.apache.org Received: (qmail 61319 invoked from network); 27 Jan 2008 19:41:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Jan 2008 19:41:55 -0000 Received: (qmail 23134 invoked by uid 500); 27 Jan 2008 19:41:46 -0000 Delivered-To: apmail-incubator-jspwiki-dev-archive@incubator.apache.org Received: (qmail 23125 invoked by uid 500); 27 Jan 2008 19:41:46 -0000 Mailing-List: contact jspwiki-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jspwiki-dev@incubator.apache.org Delivered-To: mailing list jspwiki-dev@incubator.apache.org Received: (qmail 23116 invoked by uid 99); 27 Jan 2008 19:41:46 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Jan 2008 11:41:46 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Jan 2008 19:41:27 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 58F6E714201 for ; Sun, 27 Jan 2008 11:41:34 -0800 (PST) Message-ID: <14417741.1201462894353.JavaMail.jira@brutus> Date: Sun, 27 Jan 2008 11:41:34 -0800 (PST) From: "Janne Jalkanen (JIRA)" To: jspwiki-dev@incubator.apache.org Subject: [jira] Resolved: (JSPWIKI-166) NullPointerException when mail.from property is omitted/commented out In-Reply-To: <26775130.1201427255516.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JSPWIKI-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janne Jalkanen resolved JSPWIKI-166. ------------------------------------ Resolution: Fixed Fixed in 2.6.1-rc-1. > NullPointerException when mail.from property is omitted/commented out > --------------------------------------------------------------------- > > Key: JSPWIKI-166 > URL: https://issues.apache.org/jira/browse/JSPWIKI-166 > Project: JSPWiki > Issue Type: Bug > Components: Core & storage > Affects Versions: 2.6.1 > Reporter: Florian Holeczek > Priority: Minor > Fix For: 2.6.1 > > > In line 266 of MailUtil.java: > {code}String from = engine.getWikiProperties().getProperty( PROP_MAIL_SENDER ).trim();{code} > If this property isn't defined, getProperty returns null. > Apart from fixing this, it would be fine to redesign the comments in jspwiki.properties and let the admin know that mail.from must be defined in each case, whether jndi mail or custom mail is defined. > Hint to a more general approach: > I've seen that Properties can have a set of default properties. Doesn't JSPWiki use this feature? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.