Mailing-List: contact jspwiki-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jspwiki-dev@incubator.apache.org
Message-ID: <7585494.1198707883522.JavaMail.jira@brutus>
Date: Wed, 26 Dec 2007 14:24:43 -0800 (PST)
From: "Stephen Solka (JIRA)" <jira@apache.org>
To: jspwiki-dev@incubator.apache.org
Subject: [jira] Commented: (JSPWIKI-115) Change VariableManager.getValue to
 use reflection instead of a series of if statements
In-Reply-To: <8136810.1198697863029.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/JSPWIKI-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554476 ] 

Stephen Solka commented on JSPWIKI-115:
---------------------------------------

Since currently we lowercase varnames prior to processing do you think getvarname() would look odd? example getusername(). Normally with beans its getUsername(). Should I capitalize the first letter before obtaining the methods that way they stick to the bean standard or should I just change var_ to get?

> Change VariableManager.getValue to use reflection instead of a series of if statements
> --------------------------------------------------------------------------------------
>
>                 Key: JSPWIKI-115
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-115
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Core & storage
>            Reporter: Stephen Solka
>            Priority: Minor
>         Attachments: var_reflection.patch
>
>
> A fixme tag was on getValue about cleaning up how system variables were handled. Currently a series of if else blocks goes through and designates a response for specific variables names.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.