incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Solka (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JSPWIKI-115) Change VariableManager.getValue to use reflection instead of a series of if statements
Date Wed, 26 Dec 2007 22:24:43 GMT

    [ https://issues.apache.org/jira/browse/JSPWIKI-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554476
] 

Stephen Solka commented on JSPWIKI-115:
---------------------------------------

Since currently we lowercase varnames prior to processing do you think getvarname() would
look odd? example getusername(). Normally with beans its getUsername(). Should I capitalize
the first letter before obtaining the methods that way they stick to the bean standard or
should I just change var_ to get?

> Change VariableManager.getValue to use reflection instead of a series of if statements
> --------------------------------------------------------------------------------------
>
>                 Key: JSPWIKI-115
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-115
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Core & storage
>            Reporter: Stephen Solka
>            Priority: Minor
>         Attachments: var_reflection.patch
>
>
> A fixme tag was on getValue about cleaning up how system variables were handled. Currently
a series of if else blocks goes through and designates a response for specific variables names.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message