incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Jaquith (JIRA)" <>
Subject [jira] Resolved: (JSPWIKI-33) Test webapps for web testing don't get undeployed
Date Fri, 21 Dec 2007 04:34:43 GMT


Andrew Jaquith resolved JSPWIKI-33.

       Resolution: Fixed
    Fix Version/s: 2.6.0
         Assignee: Andrew Jaquith

Resolved in 2.6.0-RC5. The fix solves two issues.

First, I've removed the dependencies on non-JSPWiki.jar classes, which should solve the WikiBackgroundThread
error issue. The Logger instance was private, so there is no risk of breaking compatibility
with subclasses. Also, the informational messages about starting/stopping/interrupting background
threads aren't really that helpful unless you are debugging. So there's no real loss to keeping
it out of the regular JSPWiki logs.

Second, the actual failure to unload the webapps was a feature, albeit not a well-documented
one. In previous versions, the webtests-teardown task in webtests.xml actually did NOT tear
down test webapps UNLESS the property webtest.teardown was set. This was in fact how things
were supposed to work because running web tests inside Eclipse for debugging needs to have
webtests to run against.

However -- this was highly counter-intuitive. The default behavior, now, is to tear the webapps
down. If testers need to keep the webapps up after the test run, setting the property "webtests.keepup"
will keep them up. 

> Test webapps for web testing don't get undeployed
> -------------------------------------------------
>                 Key: JSPWIKI-33
>                 URL:
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Core & storage
>         Environment: windows xp, tomcat 5.5.25, JSPWiki 2.5.153cvs
>            Reporter: Juan Pablo Santos Rodríguez
>            Assignee: Andrew Jaquith
>            Priority: Minor
>             Fix For: 2.6.0
> Test webapps used for web testing don't get totally or correctly undeployed. Almost all
of the webapp gets deleted except WEB-INF/lib/JSPWiki.jar, so after a few seconds it appears
as deployed in the tomcat manager. If I try to undeploy them again I get this Exception on
Tomcat (tried to undeploy them with Tomcat Manager and with build.xml script, same results
on both):
> java.lang.IllegalStateException
>         at org.apache.catalina.loader.WebappClassLoader.loadClass(
>         at org.apache.catalina.loader.WebappClassLoader.loadClass(
>         at java.lang.ClassLoader.loadClassInternal(
>         at org.apache.log4j.spi.LoggingEvent.<init>(
>         at org.apache.log4j.Category.forcedLog(
>         at org.apache.log4j.Category.error(
>         at
> Exception in thread "JSPWiki Lucene Indexer" java.lang.NoClassDefFoundError: org/apache/log4j/spi/VectorWriter
>         at org.apache.log4j.spi.LoggingEvent.<init>(
>         at org.apache.log4j.Category.forcedLog(
>         at org.apache.log4j.Category.error(
>         at
> 10-nov-2007 17:07:11 org.apache.catalina.loader.WebappClassLoader loadClass
> So it seems that this WikiBackgroundThread is not properly closed.. hadn't many time
to look into it althought

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message