incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Janne Jalkanen <Janne.Jalka...@ecyrd.com>
Subject Re: Vote: 2.6.0 release
Date Fri, 09 Nov 2007 07:21:18 GMT

Yup, I like this approach better.  It's very similar to what we are  
already doing with the footer and the MoreMenu.  No need to confuse a  
developer with multiple approaches to the same basic problem.

/Janne

On 9 Nov 2007, at 08:59, Dirk Frederickx wrote:

> Murray,
>
> No need for a patch, it's only a one line extra in the Header.jsp  ;-)
>
> Also, no need for display:none. When the TitleBox wikipage doesn't
> exist or is empty, nothing will be shown.
> Very simple, similar to the way copyrightNotice is handled.
>
>
> dirk
>
> On Nov 8, 2007 10:33 PM, Murray Altheim <murray07@altheim.com> wrote:
>> Dirk Frederickx wrote:
>>> Murray,
>>>
>>> Sound like a good idea. Similar to CopyrightNotice in the footer, we
>>> could add a title box in the header.
>>>
>>> I would prefer not to put any predefined format or contents in it
>>> (like suggested in your previous patch) but only show  that content
>>> when the page exists.
>>> So, a new block could be added to the header:
>>>
>>> <div class="titlebox"><wiki:InsertPage page="TitleBox"/></div>
>>
>> That's fine, I'll make that change and submit a patch. We'll still
>> probably want to hide the TitleBlock.jsp by default in jspwiki.css.
>>
>>> Any votes for this ?
>>
>> Well, one from me. :-)
>>
>>
>> Murray
>>
>> ..................................................................... 
>> ......
>> Murray Altheim <murray07 at altheim.com>                            
>> ===  = =
>> http://www.altheim.com/murray/                                      
>> = =  ===
>> SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk                
>> = =  = =
>>
>>        Boundless wind and moon - the eye within eyes,
>>        Inexhaustible heaven and earth - the light beyond light,
>>        The willow dark, the flower bright - ten thousand houses,
>>        Knock at any door - there's one who will respond.
>>                                        -- The Blue Cliff Record
>>


Mime
View raw message