Return-Path: X-Original-To: apmail-incubator-jena-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-jena-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 59D909D75 for ; Tue, 31 Jan 2012 21:30:20 +0000 (UTC) Received: (qmail 58838 invoked by uid 500); 31 Jan 2012 21:30:19 -0000 Delivered-To: apmail-incubator-jena-dev-archive@incubator.apache.org Received: (qmail 58536 invoked by uid 500); 31 Jan 2012 21:30:19 -0000 Mailing-List: contact jena-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jena-dev@incubator.apache.org Delivered-To: mailing list jena-dev@incubator.apache.org Received: (qmail 58432 invoked by uid 99); 31 Jan 2012 21:30:19 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Jan 2012 21:30:19 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Jan 2012 21:30:18 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 868F6181F0A for ; Tue, 31 Jan 2012 21:29:58 +0000 (UTC) Date: Tue, 31 Jan 2012 21:29:58 +0000 (UTC) From: "Rob Vesse (Updated) (JIRA)" To: jena-dev@incubator.apache.org Message-ID: <2056547813.42.1328045398552.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1685444710.41.1328045398509.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (JENA-207) FmtUtils.stringForNode() does not escape tab characters MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/JENA-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Vesse updated JENA-207: --------------------------- Attachment: FmtUtilsTabEscaping.patch Fix for FmtUtils.stringEsc() so that it actually escapes tab characters Also includes an additional test for SPARQL TSV output which was how I spotted this bug originally > FmtUtils.stringForNode() does not escape tab characters > ------------------------------------------------------- > > Key: JENA-207 > URL: https://issues.apache.org/jira/browse/JENA-207 > Project: Jena > Issue Type: Bug > Components: ARQ > Affects Versions: ARQ 2.9.0 > Reporter: Rob Vesse > Fix For: ARQ 2.9.1 > > Attachments: FmtUtilsTabEscaping.patch > > Original Estimate: 10m > Remaining Estimate: 10m > > FmtUtils.stringForNode() delegates literal formatting to FmtUtils.stringForLiteral() which delegates string escaping to stringEsc() > The issue is that the whitespace escaping section has code to deal with escaping tab characters but has a logical flaw which means tab characters won't hit that code path, the if statement surrounding the white space escapes section checks for the other kinds of whitespace characters but not for tab -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira