Return-Path: X-Original-To: apmail-incubator-jena-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-jena-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CAE7C705C for ; Tue, 18 Oct 2011 20:43:32 +0000 (UTC) Received: (qmail 10213 invoked by uid 500); 18 Oct 2011 20:43:32 -0000 Delivered-To: apmail-incubator-jena-dev-archive@incubator.apache.org Received: (qmail 10149 invoked by uid 500); 18 Oct 2011 20:43:32 -0000 Mailing-List: contact jena-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jena-dev@incubator.apache.org Delivered-To: mailing list jena-dev@incubator.apache.org Received: (qmail 10030 invoked by uid 99); 18 Oct 2011 20:43:32 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Oct 2011 20:43:32 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Oct 2011 20:43:31 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 2CAD830F114 for ; Tue, 18 Oct 2011 20:43:11 +0000 (UTC) Date: Tue, 18 Oct 2011 20:43:11 +0000 (UTC) From: "Stephen Allen (Updated) (JIRA)" To: jena-dev@incubator.apache.org Message-ID: <1517495848.7819.1318970591184.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <924075164.41492.1309100087574.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (JENA-76) Resourceutils.renameResource uses Iterator.remove() to make changes - not all iterators support .remove. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/JENA-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Allen updated JENA-76: ------------------------------ Attachment: JENA-76-r1185845.patch Improved the patch a bit by removing the need for storing two lists. > Resourceutils.renameResource uses Iterator.remove() to make changes - not all iterators support .remove. > -------------------------------------------------------------------------------------------------------- > > Key: JENA-76 > URL: https://issues.apache.org/jira/browse/JENA-76 > Project: Jena > Issue Type: Bug > Components: Jena > Reporter: Andy Seaborne > Attachments: JENA-76-r1185803.patch, JENA-76-r1185845.patch > > > Resourceutils.renameResource uses Iterator.remove() to make changes. TDB does not support Iterator.remove > Instead, renameResource could grab a block (say, 1000) items, rename them and loop on blocks of 1000. This way, the iterator is terminated before updates are done. The nature of the rename operation means that the find iterator is executed until no resources are found so this batching mechanism does not need to need to track what has and has not been found - just repeat until less than 1000 items found. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira